Skip to content

fix(web): handle thread details context clicks - #13323

Merged
Yash-Singh1 merged 1 commit into
t3code/codex-turn-mappingfrom
fix-branch-context-menu-ov2
Sep 24, 2026
Merged

Yash-Singh1 merged 1 commit into
t3code/codex-turn-mappingfrom
fix-branch-context-menu-ov2

Conversation

@Yash-Singh1

Copy link
Copy Markdown
Collaborator

Right-clicking or Ctrl-clicking the branch selector could open the refs search instead of its context menu. The Workspace row also lacked a way to copy the full checkout or worktree path.

Stop secondary mouse presses from reaching the selectors, and add a Copy full path context menu action when a workspace path is available. The thread details spacing remains unchanged.

Screenshots

Copy full path menu:

Copy full path context menu

Thread details before, with the changes stashed:

Thread details before

Thread details after, with the stash popped:

Thread details after

The before and after panel captures have zero differing pixels. Verified in Helium; focused lint, formatting, and web typecheck passed.

Model: GPT-6 Astra. Harness: Codex.

Stop branch menu mouse events from opening selectors and add a Copy full path action for workspace context menus.
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 4.9 KiB — 6.8 KiB ✅
Codex Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Codex Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Codex Live turn WebSocket decoded — 20.4 KiB — 29.3 KiB ✅
Codex Live turn messages — 2 — 8 ✅
Claude Total thread wire — 4.9 KiB — 6.8 KiB ✅
Claude Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Claude Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Claude Live turn WebSocket decoded — 20.8 KiB — 29.3 KiB ✅
Claude Live turn messages — 2 — 8 ✅

Baseline: unavailable · PR result: 41b5b7c · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 106.1 KiB
  • Claude decoded thread snapshot: 106.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeapp Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 41b5b7c

Macroscope's review found this PR approvable — These localized web UI changes prevent secondary clicks from opening selectors and add an explicit workspace context-menu action for copying an available path. Normal left-click behavior remains unchanged, and there are no schema, deployment, security, billing, default, or static-analysis configuration changes.

You can add or adjust custom eligibility rules. Learn more.

@Yash-Singh1
Yash-Singh1 merged commit 5113cdc into t3code/codex-turn-mapping Sep 24, 2026
24 checks passed
@Yash-Singh1
Yash-Singh1 deleted the fix-branch-context-menu-ov2 branch September 24, 2026 01:31
@Yash-Singh1
Yash-Singh1 restored the fix-branch-context-menu-ov2 branch September 24, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant