Repository navigation
fix: allow 100 MB file uploads without raising native media limits #13261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -166,7 +166,7 @@ export const PROVIDER_SEND_TURN_MAX_INPUT_CHARS = 120_000; | |
| export const PROVIDER_SEND_TURN_MAX_ATTACHMENTS = 100; | ||
| export const PROVIDER_SEND_TURN_MAX_IMAGE_BYTES = 10 * 1024 * 1024; | ||
| const PROVIDER_SEND_TURN_MAX_TOTAL_IMAGE_BYTES = 80 * 1024 * 1024; | ||
| export const PROVIDER_SEND_TURN_MAX_FILE_BYTES = 50 * 1024 * 1024; | ||
| export const PROVIDER_SEND_TURN_MAX_FILE_BYTES = 100_000_000; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Blocker (see review summary): this constant also bounds
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed. I opened #13429 against |
||
| export const PROVIDER_SEND_TURN_SUPPORTED_IMAGE_MIME_TYPES = [ | ||
| "image/gif", | ||
| "image/jpeg", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge trap with #13339: that PR keeps
MAX_TOTAL_ATTACHMENT_BYTES = PROVIDER_SEND_TURN_MAX_FILE_BYTESon this line, and the two PRs conflict here. If that side wins, the native budget silently becomes 100 MB, while the error message and the Antigravity user docs still say 50 MiB. Keep this 50 MiB literal whichever PR lands second.