-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(models): defer effort and context to provider settings #13258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+120
−137
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4c8fed5
fix(context): apply Claude and Codex window choices
Bil0000 3073888
fix(test): allow JSON in Codex mock fixture
Bil0000 c39f5bf
fix(codex): serialize context forks and stop targeting
Bil0000 8c223ec
fix(codex): reset unsupported model context and keep Stop responsive
Bil0000 c1dfb7d
fix(context): preserve Claude work and use native GPT defaults
Bil0000 3afde43
fix(claude): restart when selecting 1M from unset window
Bil0000 ff0bad4
fix(codex): protect queued turns and Stop during context forks
Bil0000 f24af30
fix(codex): bound stopped turns and avoid stale completions
Bil0000 7e90300
fix(codex): close session when Stop cannot be confirmed
Bil0000 4692017
ci: retry flaky VCS test shard
Bil0000 7237fd5
feat(context): discover Codex limits for new GPT models
Bil0000 45cde4b
chore(context): explain Codex cache imports
Bil0000 6f9c80f
fix(models): defer Claude and Codex effort to provider settings
Bil0000 36d1bc4
fix(codex): stop the active turn before queued follow-ups
Bil0000 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropping
contextWindowhere also drops the manifest's default[1m]suffix:claude-opus-5-5[1m]becomesclaude-opus-5-5, andclaude-opus-4-6[1m]becomesclaude-opus-4-6. That means 200K for Opus 4.6 everywhere and for third-party routes, and settings cannot restore it because T3 passes an explicit--model. See blocker 2.