Skip to content

fix(settings): explain that provider update checks also fetch model catalog updates - #13257

Open
Marve10s wants to merge 1 commit into
pingdotgg:mainfrom
Marve10s:fix/provider-update-checks-copy
Open

Marve10s wants to merge 1 commit into
pingdotgg:mainfrom
Marve10s:fix/provider-update-checks-copy

Conversation

@Marve10s

@Marve10s Marve10s commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

What Changed

The Provider update checks setting now says what it controls on both web and mobile:

  • Web: "Check installed provider CLIs for newer available versions and fetch model catalog updates."
  • Mobile: "Check installed provider CLIs for newer versions and fetch model catalog updates."

Fixes #13244.

Why

Turning this setting off also stops the server from fetching the remote model manifest (ModelManifest.refresh returns before the network call, including on an explicit Refresh provider status). Since #9084, that manifest is how new Claude models show up between releases. The old copy only mentioned CLI version checks, so users who turned it off saw new models go missing with no hint why.

The gate itself is deliberate, as the triage on #13244 explains, so this changes the copy to state the coupling rather than changing behavior. A manifest already cached on disk still applies, so the text says the setting fetches updates, not that it removes models.

UI Changes

Text-only change to one settings description on web and one on mobile. The before and after strings are above.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes (text-only; strings quoted above)
  • I included a video for animation/interaction changes

Implemented with Claude Opus 5.5 in Claude Code, reviewed with Claude Fable 5.1.

Summary by CodeRabbit

  • Documentation
    • Updated the provider update setting description to clarify that checks for newer CLI versions also fetch model catalog updates.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 23, 2026
@macroscopeapp

This comment has been minimized.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: e292d46c-05c3-48f8-8324-c73334d28a83

📥 Commits

Reviewing files that changed from the base of the PR and between f5ef0dd and d51404e.

📒 Files selected for processing (2)
  • apps/mobile/src/features/settings/SettingsServerControlsRouteScreen.tsx
  • apps/web/src/components/settings/SettingsPanels.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The mobile and web descriptions for provider update checks now mention fetching model catalog updates in addition to checking installed provider CLIs.

Changes

Provider update setting copy

Layer / File(s) Summary
Update provider check descriptions
apps/mobile/src/features/settings/SettingsServerControlsRouteScreen.tsx, apps/web/src/components/settings/SettingsPanels.tsx
Both settings descriptions now mention fetching model catalog updates alongside checking for newer provider CLI versions.

Priority: ⚪ Not assessed

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other · Severity of issue fixed: Low

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to d5140

The updated descriptions explain that provider update checks also fetch model catalog updates. No unresolved merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning Issue #13244 requires independent model metadata refresh, or a clear explanation of the coupling with a separate refresh. The web and mobile changes add the coupling explanation. The reviewed diff add… Add an independent model-catalog refresh action that works when Provider update checks are disabled, or implement model metadata refresh independently from the provider CLI check setting.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely states the main change: it explains that provider update checks also fetch model catalog updates.
Description check ✅ Passed The description is complete and focused. It explains what changed, why the change is needed, the affected UI, and the behavior that remains unchanged. It also identifies the text-only nature of the UI…
Out of Scope Changes check ✅ Passed The changes modify only the Provider update checks description in the web and mobile settings. These changes directly support issue #13244 by explaining that the setting also fetches model catalog upd…
Full details: Linked Issues check

Explanation

Issue #13244 requires independent model metadata refresh, or a clear explanation of the coupling with a separate refresh. The web and mobile changes add the coupling explanation. The reviewed diff adds no separate model-catalog refresh and does not change the manifest-fetch gate. Therefore, the implementation does not establish the complete alternative requested by the issue.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@macroscopeapp

macroscopeapp Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at d51404e

Macroscope's review found this PR approvable — This PR only updates the mobile and web settings descriptions to document existing model catalog update behavior. Setting values, defaults, handlers, and runtime operations remain unchanged.

You can add or adjust custom eligibility rules. Learn more.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Disabling CLI update checks also blocks new model catalog

1 participant