Conversation
This comment has been minimized.
This comment has been minimized.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe mobile and web descriptions for provider update checks now mention fetching model catalog updates in addition to checking installed provider CLIs. ChangesProvider update setting copy
Priority: ⚪ Not assessed Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other · Severity of issue fixed: Low Suggested reviewers: Merge Risk: ⚪ Minimal · up to The updated descriptions explain that provider update checks also fetch model catalog updates. No unresolved merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Linked Issues checkExplanation Issue
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This PR only updates the mobile and web settings descriptions to document existing model catalog update behavior. Setting values, defaults, handlers, and runtime operations remain unchanged. You can add or adjust custom eligibility rules. Learn more. |
What Changed
The Provider update checks setting now says what it controls on both web and mobile:
Fixes #13244.
Why
Turning this setting off also stops the server from fetching the remote model manifest (
ModelManifest.refreshreturns before the network call, including on an explicit Refresh provider status). Since #9084, that manifest is how new Claude models show up between releases. The old copy only mentioned CLI version checks, so users who turned it off saw new models go missing with no hint why.The gate itself is deliberate, as the triage on #13244 explains, so this changes the copy to state the coupling rather than changing behavior. A manifest already cached on disk still applies, so the text says the setting fetches updates, not that it removes models.
UI Changes
Text-only change to one settings description on web and one on mobile. The before and after strings are above.
Checklist
Implemented with Claude Opus 5.5 in Claude Code, reviewed with Claude Fable 5.1.
Summary by CodeRabbit