fix(desktop): resolve Windows userData without yielding before the Clerk bridge

[SunkenInTime]

Closes #13195

What Changed

DesktopClerk.make now runs DesktopUserData.resolveUserDataPath against a synchronous node:fs-backed FileSystem (existsSync, readFileSync, mkdirSync, writeFileSync, errno mapped to PlatformError.systemError so the wx / AlreadyExists write path still works). The resolver, its tests, and the setPath("userData") before createClerkBridge order are unchanged.

Regression test in DesktopClerk.test.ts: builds the layer under Effect.runSync with an ambient FileSystem whose exists is deferred, for packaged Windows and for development. Any yield before createClerkBridge throws AsyncFiberError. Both cases fail on the current branch and pass with this change.

Why

Every packaged Windows launch of the V2 branch exits with code 1 before a window appears:

ERROR (#4): DesktopClerkBridgeInitializationError: Failed to initialize the desktop Clerk bridge for state directory "C:\Users\<user>\.t3\userdata" (development: false).
  [cause]: Error: protocol.registerSchemesAsPrivileged should be called before app is ready
      at createClerkBridge (...\app.asar\apps\desktop\dist-electron\main.cjs:119042:22)
      at createDesktopClerkBridge (...\main.cjs:128507:9)

Since #12480, resolveUserDataPath inspects the profile directories on win32 (and the legacy profile in development on every platform) through the Effect Node FileSystem. exists there is async, so the startup fiber yields, Electron emits ready during that yield, and @clerk/electron's registerSchemesAsPrivileged throws. Non-Windows packaged builds return before any I/O, which is why macOS is unaffected. Creating the bridge before resolving userData is not an option because the bridge takes the single-instance lock in the userData directory, so the I/O has to stop yielding instead. This is the approach @juliusmarminge described in the issue.

Verification

Windows Server 2022 x64, Node 24.13.1, pnpm 11.10.0, Electron 44.4.2, branch t3code/codex-turn-mapping at 060756de5.

Before: pnpm dist:desktop:win:x64, install release\T3-Code-0.0.42-x64.exe /S, run T3 Code (Alpha).exe --enable-logging=stderr. Process exits with code 1 in about one second with the error above.

After: same build and install steps. The process stays up, the onboarding window opens, and GET http://127.0.0.1:3773/.well-known/t3/environment returns 200 with serverVersion 0.0.42.

Before	After

Checks: apps/desktop typecheck exit 0, vp lint and vp fmt --check clean on the two changed files, DesktopClerk.test.ts 7/7. DesktopUserData.test.ts > identifies a failed source read and preserves its cause fails on this Windows machine both before and after this change (path separator in the expected error), so it is not related.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This focused fix changes production desktop startup by introducing synchronous filesystem access before Clerk bridge registration. It also adds file- and line-level static-analysis suppressions, so the change warrants human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[macroscopeapp]

Effect Service Conventions found one blocking issue in apps/desktop/src/app/DesktopClerk.ts: service construction hides the filesystem dependency behind a module-global concrete implementation instead of acquiring it from the Effect environment. See the inline review comment for the expected application-layer composition fix.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Effect Service Conventions found one blocking issue in apps/desktop/src/app/DesktopPreReadyFileSystem.ts: the implementation module exposes only an inline layer rather than canonical make and layer values. See the inline review comment for the suggested fix.

^{Posted via Macroscope — Effect Service Conventions}