chore(mobile): name the two project favicon caches by their job

[juliusmarminge]

The problem

Mobile shipped two different projectFaviconCache.ts files with the same basename and different jobs: src/components/projectFaviconCache.ts tracked in-flight favicon image requests, while src/lib/projectFaviconCache.ts was the SQLite-backed persistent cache. The mobile singleton was also named projectFaviconCache, the same name as the shared client-runtime factory it calls. Navigation and agents routinely landed on the wrong file (mobile audit item #9 flagged this collision).

The fix

Pure renames plus two module doc comments — no behavior changes:

• src/components/projectFaviconCache.ts (+ test) → src/lib/projectFaviconRequests.ts, since it is request bookkeeping, not a cache, and has no React in it. Added a module comment saying it pairs with the database cache.
• src/lib/projectFaviconCache.ts (+ test) → src/lib/projectFaviconDatabaseCache.ts, and its singleton projectFaviconCache → projectFaviconDatabaseCache, so it no longer shadows the createProjectFaviconCache factory name from @t3tools/client-runtime/project-favicon-cache.
• Updated the four import sites (ProjectFavicon.tsx, state/assets.ts, state/client-cache-state.ts, connection/environment-cache-store.ts). The public function names in the request module are unchanged.

Left alone deliberately: the client-runtime package file (cross-app contract, not flagged in the audit) and every other file in the audit's broader naming findings — one collision per PR.

Verification

• vp test run src/lib/projectFaviconRequests.test.ts src/lib/projectFaviconDatabaseCache.test.ts — 9 passed (both suites cover the renamed modules directly).
• tsc --noEmit for apps/mobile — clean.
• vp lint apps/mobile/src — no new findings on touched files (the one ProjectFavicon.tsx warning is pre-existing on untouched lines).

Not applicable: screenshots — no visual or runtime change; the diff is renames, identifier updates, and comments.

Model: Claude Opus 5 via Codex, working inside T3 Code.

---

Summary by CodeRabbit

• Refactor

  • Reorganized mobile project favicon caching and request handling into clearer, dedicated components.
  • Updated environment loading, asset handling, and cache invalidation to use the revised favicon cache structure.
  • Preserved existing favicon storage, image-loading, and caching behavior.

• Documentation

  • Clarified favicon request tracking and persistence responsibilities.

• Tests

  • Updated test references and descriptions to reflect the revised favicon cache organization without changing coverage.

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.5 KiB	13.5 KiB	−26 B (−0.2%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.1 KiB	7.1 KiB	+4 B (+0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.5 KiB	−30 B (−0.5%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	56.3 KiB	56.3 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.5 KiB	13.5 KiB	+5 B (+0.0%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.1 KiB	7.1 KiB	−1 B (−0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	+6 B (+0.1%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	9	9	0 (0.0%)	21	✅

Baseline: bed0b4c · PR result: bfcf42c · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 114.0 KiB
• Claude decoded thread snapshot: 114.7 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at bfcf42c

Macroscope's review found this PR approvable — This is a self-contained mechanical rename that separates favicon request bookkeeping from the database-backed cache without changing their implementations, storage keys, or call-site behavior. Tests and all mobile references were updated accordingly, with no product-default or static-analysis configuration changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: e25f3e62-7b8b-4f35-942b-f6c33b05a5d3

📥 Commits

Reviewing files that changed from the base of the PR and between c325978 and bfcf42c.

📒 Files selected for processing (1)

• apps/mobile/src/lib/projectFaviconRequests.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• apps/mobile/src/lib/projectFaviconRequests.ts

Limit details: You’ve used all 10 included reviews currently available.

---

📝 Walkthrough

Walkthrough

The mobile project favicon cache is separated into request and database-cache modules. The database-backed cache is renamed to projectFaviconDatabaseCache, and related environment, asset, client-cache, component, and test references are updated.

Changes

Project favicon cache

Layer / File(s)	Summary
Cache module separation apps/mobile/src/lib/projectFaviconDatabaseCache.ts, apps/mobile/src/lib/projectFaviconRequests.ts, apps/mobile/src/lib/*test.ts	The database cache export is renamed to projectFaviconDatabaseCache. Request documentation and test imports reflect the separate modules.
Environment cache wiring apps/mobile/src/connection/environment-cache-store.ts	Environment cache loading hydrates the renamed database cache. Environment clearing uses its clearEnvironment method.
Consumer updates apps/mobile/src/components/ProjectFavicon.tsx, apps/mobile/src/state/assets.ts, apps/mobile/src/state/client-cache-state.ts	Favicon request helpers and database-cache consumers use the updated module names and export. Global and environment-scoped cache clearing use projectFaviconDatabaseCache.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to bfcf4

The rename and documentation updates preserve favicon request and database-cache behavior, so the change is mergeable with normal checks.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: naming the two mobile project favicon modules by their distinct responsibilities.
Description check	✅ Passed	The description clearly explains the problem, the rename-based fix, the unchanged behavior, affected modules, verification steps, and why UI screenshots are not applicable. It does not use the templat…
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 8 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

Dismissing prior approval to re-evaluate c325978

[macroscopeapp]

All clear

^{Posted via Macroscope — Effect Service Conventions}

Dismissing prior approval to re-evaluate bfcf42c