Conversation
The Project page only held name, icon, actions and removal, so a project's default model had no obvious home. It now renders the same New threads rows as General and lists every other setting the project overrides, each linking to the row that edits it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The PR adds editable project-level new-thread defaults and an override/reset surface that can change future thread behavior. An unresolved medium-severity finding also reports that some persisted model overrides may be hidden when their provider is disabled, leaving no visible reset path. Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (10)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe Project settings page now displays general defaults and project-scoped overrides edited elsewhere. Override rows show formatted or mixed values and link to the relevant settings section. The override list is derived from scoped settings sources and sorted by sidebar section. ChangesProject settings overrides
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant ProjectSettingsPanel
participant useSettingsScope
participant listedProjectOverrides
participant settingsSearchItem
participant SettingsPage
ProjectSettingsPanel->>useSettingsScope: Read the current settings scope
ProjectSettingsPanel->>listedProjectOverrides: Pass scoped settings targets
listedProjectOverrides->>settingsSearchItem: Resolve each override itemId
settingsSearchItem-->>listedProjectOverrides: Return the settings search item
listedProjectOverrides-->>ProjectSettingsPanel: Return ordered override items
ProjectSettingsPanel->>SettingsPage: Link to the editing section with highlight state
Possibly related PRs
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The Project settings additions have no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 16 functions across 9 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
The Project settings page lost its default model picker when overrides moved onto the category pages. You now have to know to keep the project selected and go to General. The page opened from "Project settings" showed only the name, icon, actions, and removal, so it felt empty.
The Project page now shows:
A typed map sets the page where each overridable setting is edited. If someone adds a new project-scoped key, the build fails until they add it to the map. The source control writing style rows now accept a project scope in search, because they already render and write overrides.
Web and desktop only. Mobile has its own Project overview and does not change.
I checked this in the web client against a copy of real data. The Overrides row opens Source Control with the project scope kept and focuses the row.
Created with Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code
Summary by CodeRabbit