Skip to content

fix(web): show menu chevrons on breadcrumb dropdowns - #13101

Closed
flamboh wants to merge 2 commits into
pingdotgg:mainfrom
flamboh:add-dropdown-icons
Closed

flamboh wants to merge 2 commits into
pingdotgg:mainfrom
flamboh:add-dropdown-icons

Conversation

@flamboh

@flamboh flamboh commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Note

🤖 Claude Opus 5.5 on behalf of Oliver

Important

Stack, bottom (merge first). #13104 is stacked on this PR. Both target main because the stack lives on a fork.

Problem

The Settings breadcrumb's environment and project crumbs open menus but look like plain text. Other breadcrumb menus (usage environment filter, chat thread title) each hand-rolled a chevron that only appeared on hover.

Fix

Add WorkspaceBreadcrumbChevron, an always-visible muted chevron, and use it for every breadcrumb that opens a menu: the Settings environment/project crumbs, the usage environment filter, and the chat thread title. The usage filter still swaps in its scanning/warning icon when one applies.

UI Changes

Before

Settings breadcrumb before

After

Settings breadcrumb after


Made with Claude Opus 5.5 in Claude Code (via T3 Code); screenshot by GPT-5.6 Luna in Codex.

Summary by CodeRabbit

  • Style
    • Standardized dropdown and breadcrumb chevrons across chat thread menus, settings scope menus, and usage environment filters.
    • Updated chevron styling for a smaller, muted appearance with more consistent visibility and alignment.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 22, 2026
@flamboh
flamboh marked this pull request as ready for review September 22, 2026 17:53
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 22, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 84023d7

Macroscope's review found this PR approvable — The PR makes a small, self-contained UI adjustment that consistently exposes chevrons for existing dropdown controls. It does not change menu behavior, data handling, schemas, deployment, or other sensitive areas.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeapp
macroscopeapp Bot dismissed their stale review September 22, 2026 17:58

Dismissing prior approval to re-evaluate 84023d7

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 36796817-188b-487f-9b83-8f6925065307

📥 Commits

Reviewing files that changed from the base of the PR and between 7c2702d and 84023d7.

📒 Files selected for processing (6)
  • apps/web/src/components/WorkspaceBreadcrumb.tsx
  • apps/web/src/components/chat/ChatHeader.tsx
  • apps/web/src/components/settings/SettingsBreadcrumb.tsx
  • apps/web/src/components/usage/UsagePage.refresh.test.tsx
  • apps/web/src/components/usage/UsagePage.test.tsx
  • apps/web/src/components/usage/UsagePage.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The change adds a shared breadcrumb chevron component and uses it in chat, settings, and usage controls. Usage tests mock the new export.

Changes

Breadcrumb chevron standardization

Layer / File(s) Summary
Shared chevron component
apps/web/src/components/WorkspaceBreadcrumb.tsx
Exports WorkspaceBreadcrumbChevron with standard sizing, muted coloring, accessibility attributes, and forwarded icon props.
Control adoption
apps/web/src/components/chat/ChatHeader.tsx, apps/web/src/components/settings/SettingsBreadcrumb.tsx, apps/web/src/components/usage/UsagePage.tsx, apps/web/src/components/usage/UsagePage*.test.tsx
Chat, settings, and usage controls use the shared chevron. Usage removes local chevron visibility styling, and tests mock the new export.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 84023

No actionable merge-blocking risk remains in this UI-only change.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 6 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: showing menu chevrons on breadcrumb dropdowns.
Description check ✅ Passed The description explains the problem and fix, identifies the affected breadcrumb menus, and includes before-and-after UI screenshots. The checklist section is omitted, but the description is otherwise…
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

flamboh and others added 2 commits September 22, 2026 18:50
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@flamboh

flamboh commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

Note

🤖 Claude Opus 5.5 on behalf of Oliver

Closing as superseded. #13139 moved the settings scope pickers out of the breadcrumb, and they now show an always-visible chevron. #13042 added InlineButton with a picker tone, which covers the shared-trigger idea. #13104 no longer depends on this PR.

@flamboh flamboh closed this Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant