-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(mobile): preserve filters across layout changes #13085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PixPMusic
wants to merge
2
commits into
pingdotgg:main
Choose a base branch
from
PixPMusic:fix/android-fold-search-state
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+132
−11
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| import { EnvironmentId } from "@t3tools/contracts"; | ||
| import { act, createElement, useLayoutEffect } from "react"; | ||
| import { createRoot, type Root } from "react-dom/client"; | ||
| import { afterEach, beforeEach, describe, expect, it, vi } from "vite-plus/test"; | ||
|
|
||
| import { HomeListOptionsProvider, useHomeListOptions } from "./home-list-options"; | ||
|
|
||
| describe("home list options across layout changes", () => { | ||
| const environmentId = EnvironmentId.make("environment-1"); | ||
| const availableEnvironmentIds = new Set([environmentId]); | ||
| let root: Root; | ||
| let latest: ReturnType<typeof useHomeListOptions>; | ||
|
|
||
| function ThreadList() { | ||
| const state = useHomeListOptions(availableEnvironmentIds); | ||
| useLayoutEffect(() => { | ||
| latest = state; | ||
| }); | ||
| return null; | ||
| } | ||
|
|
||
| async function showLayout(layout: "compact" | "sidebar") { | ||
| await act(() => { | ||
| root.render( | ||
| createElement( | ||
| HomeListOptionsProvider, | ||
| { projectGroupingMode: "repository" }, | ||
| // Replace the list while keeping the workspace provider mounted. | ||
| createElement(ThreadList, { key: layout }), | ||
| ), | ||
| ); | ||
| }); | ||
| } | ||
|
|
||
| beforeEach(() => { | ||
| // The hook probe renders no DOM, but ReactDOM needs an event target. | ||
| const document = { | ||
| nodeType: 9, | ||
| addEventListener() {}, | ||
| removeEventListener() {}, | ||
| }; | ||
| const container = { | ||
| nodeType: 1, | ||
| tagName: "DIV", | ||
| namespaceURI: "http://www.w3.org/1999/xhtml", | ||
| ownerDocument: document, | ||
| addEventListener() {}, | ||
| removeEventListener() {}, | ||
| }; | ||
| vi.stubGlobal("document", document); | ||
| vi.stubGlobal("window", { document, HTMLIFrameElement: EventTarget }); | ||
| vi.stubGlobal("IS_REACT_ACT_ENVIRONMENT", true); | ||
| root = createRoot(container as unknown as HTMLElement); | ||
| }); | ||
|
|
||
| afterEach(async () => { | ||
| await act(() => root.unmount()); | ||
| vi.unstubAllGlobals(); | ||
| }); | ||
|
|
||
| it.each([ | ||
| ["compact", "sidebar"], | ||
| ["sidebar", "compact"], | ||
| ] as const)( | ||
| "retains filters through repeated %s → %s round trips and keeps clears", | ||
| async (initialLayout, otherLayout) => { | ||
| await showLayout(initialLayout); | ||
|
|
||
| for (const [selectedEnvironmentId, selectedProjectKey] of [ | ||
| [environmentId, "repository:one"], | ||
| [environmentId, "repository:two"], | ||
| [environmentId, null], | ||
| [null, null], | ||
| [null, "repository:one"], | ||
| ] as const) { | ||
| await act(() => { | ||
| latest.setSelectedEnvironmentId(selectedEnvironmentId); | ||
| latest.setSelectedProjectKey(selectedProjectKey); | ||
| }); | ||
| for (let cycle = 0; cycle < 3; cycle += 1) { | ||
| for (const layout of [otherLayout, initialLayout]) { | ||
| await showLayout(layout); | ||
| expect(latest.options).toMatchObject({ | ||
| selectedEnvironmentId, | ||
| selectedProjectKey, | ||
| projectGroupingMode: "repository", | ||
| }); | ||
| } | ||
| } | ||
| // Make the next selection (or clear it) from the opposite layout. | ||
| await showLayout(otherLayout); | ||
| } | ||
| }, | ||
| ); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.