Skip to content

fix(orchestration): report subagent models and use live model choices - #13067

Merged
juliusmarminge merged 2 commits into
pingdotgg:t3code/codex-turn-mappingfrom
Bil0000:fix/v2-subagent-models
Sep 24, 2026
Merged

fix(orchestration): report subagent models and use live model choices#13067
juliusmarminge merged 2 commits into
pingdotgg:t3code/codex-turn-mappingfrom
Bil0000:fix/v2-subagent-models

Conversation

@Bil0000

@Bil0000 Bil0000 commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix subagent model labels so children show their reported model instead of the parent's. Use the composer's live model catalog for delegation, including custom models; native CLI lists remain provider-controlled.

Verified on current v2: 367 focused tests, six subagent replays, server/web type checks, lint, and formatting. Grok's replay startup failure also occurs on unchanged v2.

Model: GPT-6 Astra. Harness: Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 22, 2026
macroscopeapp[bot]
macroscopeapp Bot reviewed Sep 22, 2026
View reviewed changes

@macroscopeapp macroscopeapp Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All clear

Posted via Macroscope — Effect Service Conventions

@macroscopeapp

macroscopeapp Bot commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR changes live orchestration behavior across Codex, Claude, and Cursor, including child-model discovery, event-driven updates, delegation guidance, and UI reporting. The cross-component behavior change and broader model-selection capability are beyond a small self-contained fix.

No code changes detected at 2304e37. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 2 times, most recently from 060756d to d6dcd10 Compare September 23, 2026 04:10
@Bil0000
Bil0000 force-pushed the fix/v2-subagent-models branch from d47d271 to 2e6d52d Compare September 23, 2026 04:11
@github-actions github-actions Bot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Sep 23, 2026
@Bil0000
Bil0000 force-pushed the fix/v2-subagent-models branch from 2e6d52d to f7ff936 Compare September 23, 2026 04:14
@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Sep 23, 2026
@Bil0000

Bil0000 commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

CI status on f7ff936427: all test jobs pass. Check fails only at the shadcn/no-restyle ceiling (659 findings, limit 627). The v2 base job fails with the same count and limit; the PR job has the same result. This PR's web changes do not add style overrides.

@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 2 times, most recently from d2675dc to 9cbaf77 Compare September 23, 2026 07:35
@Bil0000
Bil0000 force-pushed the fix/v2-subagent-models branch from f7ff936 to 08bbfd8 Compare September 23, 2026 18:24
@Bil0000

Bil0000 commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

Update for 08bbfd8dc1: the PR is now 2 commits and 12 files against the current V2 base. Check, Test, all three server test shards, and the other required checks pass. My earlier no-restyle CI failure note applied to the old head and is resolved.

@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 2 times, most recently from 6ca6a24 to 3e4ca4c Compare September 23, 2026 23:24
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch from 1bd44f2 to 3b9c885 Compare September 24, 2026 04:06
@juliusmarminge
juliusmarminge merged commit 0ed23fe into pingdotgg:t3code/codex-turn-mapping Sep 24, 2026
23 checks passed
@juliusmarminge juliusmarminge mentioned this pull request Sep 24, 2026
Open
juliusmarminge added a commit to Bil0000/t3code that referenced this pull request Sep 24, 2026
@juliusmarminge @claude
fix(web): restore child model selection after rebase onto pingdotgg#1…
4a473eb 
…3067

pingdotgg#13067 dropped modelSelection from the tooltip's childThread prop and
now labels a missing reported model "Not reported". Keep modelSelection
for the effort lookup and expect no effort beside "Not reported".

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
juliusmarminge pushed a commit that referenced this pull request Sep 24, 2026
@Bil0000 @juliusmarminge
fix(orchestration): report subagent models and use live model choices (…
bfac3cf 
…#13067)
juliusmarminge pushed a commit that referenced this pull request Sep 24, 2026
@Bil0000 @juliusmarminge
fix(orchestration): report subagent models and use live model choices (…
4aaffa4 
…#13067)
Bil0000 pushed a commit to Bil0000/t3code that referenced this pull request Sep 25, 2026
@juliusmarminge @claude @Bil0000
fix(web): restore child model selection after rebase onto pingdotgg#1…
cb26500 
…3067

pingdotgg#13067 dropped modelSelection from the tooltip's childThread prop and
now labels a missing reported model "Not reported". Keep modelSelection
for the effort lookup and expect no effort beside "Not reported".

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
juliusmarminge pushed a commit that referenced this pull request Sep 25, 2026
@Bil0000 @juliusmarminge
fix(orchestration): report subagent models and use live model choices (…
1c339ef 
…#13067)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macroscopeapp macroscopeapp[bot] macroscopeapp[bot] left review comments

Assignees

No one assigned

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bil0000 @juliusmarminge