refactor(web): render menu and popover triggers through Button - #13009
juliusmarminge wants to merge 1 commit into
Conversation
github-actions
Bot
added
vouch:trusted
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
| narrowed ? "text-foreground" : "text-muted-foreground hover:text-foreground", | ||
| )} | ||
| render={<InlineButton tone={narrowed ? "default" : "muted"} />} | ||
| className="min-w-0 max-w-56 gap-1.5" |
There was a problem hiding this comment.
🟡 Medium settings/SettingsBreadcrumb.tsx:115
On narrow windows, long scope labels make the breadcrumb overflow instead of shrinking to fit. InlineButton applies shrink-0, so the trigger remains up to max-w-56 wide despite the breadcrumb item's intended shrink behavior; add a shrink utility to override it.
| className="min-w-0 max-w-56 gap-1.5" | |
| className="min-w-0 max-w-56 shrink gap-1.5" |
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/web/src/components/settings/SettingsBreadcrumb.tsx around line 115:
On narrow windows, long scope labels make the breadcrumb overflow instead of shrinking to fit. `InlineButton` applies `shrink-0`, so the trigger remains up to `max-w-56` wide despite the breadcrumb item's intended `shrink` behavior; add a shrink utility to override it.
76457fe to
bf90c08
Compare
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughShared ChangesShared trigger restyling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to The changes centralize trigger styling without an established functional regression or production-impacting risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Comment |
Six headless triggers hand-rolled a full button recipe in className. Two were the same accent pill, which is Button variant="secondary" size="xs"; four were bare text links, which is InlineButton. Render through those instead so the trigger inherits focus rings and hover from one place. Visible effect: the diff-scope pickers use the secondary token (zinc-50) instead of accent (zinc-100), one step lighter at rest. Lowers the no-restyle ceiling from 784 to 735. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
bf90c08 to
a452b96
Compare
ApprovabilityVerdict: Would Approve Macroscope's review found this PR approvable — This is a focused UI refactor that standardizes existing menu and popover triggers through shared Button variants, with localized presentation changes and no new capability, schema, deployment, security, auth, or billing behavior. A medium-severity responsive-layout finding remains for the settings breadcrumb, where long labels may overflow on narrow windows. Not approved because:
Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more. |
|
Superseded by the reworked stack (#12993 v2). After review feedback the layers were rebuilt to add fewer props and take more opinions in the base; see the new stack for the replacement. |
1 participant
Six headless triggers hand-rolled a full button recipe in className. Two
were the same accent pill, which is Button variant="secondary" size="xs";
four were bare text links, which is InlineButton. Render through those
instead so the trigger inherits focus rings and hover from one place.
Visible effect: the diff-scope pickers use the secondary token (zinc-50)
instead of accent (zinc-100), one step lighter at rest.
Lowers the no-restyle ceiling from 784 to 735.
Part of the
components/uiclassName cleanup (audit and guardrail: #12982). Each layer of stack #12993 lowers theshadcn/no-restyleceiling; CI fails if the count rises.Written by Claude Fable 5 in Claude Code.
🤖 Generated with Claude Code
Summary by CodeRabbit