refactor(web): add radius and alwaysShowScrollbars to ScrollArea - #13006
juliusmarminge wants to merge 1 commit into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, self-contained ScrollArea styling refactor that centralizes existing radius and scrollbar classes without changing defaults or introducing new workflows. The accompanying lint-ceiling change tightens the guard rather than suppressing diagnostics. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (9)
Limit details: You’ve used all 10 included reviews currently available. 📝 WalkthroughWalkthrough
ChangesScrollArea styling API migration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to ScrollArea gains optional corner-radius and always-visible scrollbar controls while existing consumers preserve their intended appearance and behavior. The change is merge-ready with normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
de1fecf to
f189bc2
Compare
f189bc2 to
bf592e9
Compare
Eight scroll areas opted out of the inherited radius with rounded-none because they sit flush to a panel edge, and two forced the scrollbar visible by reaching into its slot. Expose radius="none" and alwaysShowScrollbars and migrate the sites. No rendered change. Lowers the no-restyle ceiling from 812 to 802. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
bf592e9 to
1417da0
Compare
Eight scroll areas opted out of the inherited radius with rounded-none
because they sit flush to a panel edge, and two forced the scrollbar
visible by reaching into its slot. Expose radius="none" and
alwaysShowScrollbars and migrate the sites. No rendered change.
Lowers the no-restyle ceiling from 812 to 802.
Part of the
components/uiclassName cleanup (audit and guardrail: #12982). Each layer of stack #12993 lowers theshadcn/no-restyleceiling; CI fails if the count rises.Written by Claude Fable 5 in Claude Code.
🤖 Generated with Claude Code
Summary by CodeRabbit
Style
Chores