refactor(web): add an inline variant to Input - #13005
juliusmarminge wants to merge 1 commit into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a contained refactor that moves existing sidebar input styling into an explicitly selected inline variant while preserving the component’s default behavior. Its remaining CI change tightens a warning ceiling rather than suppressing diagnostics, so the runtime and review risk are low. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
All clear Posted via Macroscope — UI Consistency |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Limit details: You’ve used all 10 included reviews currently available. 📝 WalkthroughWalkthroughThe shared ChangesInline input styling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The sidebar search fields adopt shared inline styling without changing search behavior, and no merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
8d8b39d to
93df831
Compare
93df831 to
719cb22
Compare
The sidebar thread search and the settings search both rendered an unstyled Input and then reached into its slot with seven [&_[data-slot= input]] utilities to make it bare sidebar text. Expose that as variant="inline". The placeholder now uses sidebar-muted-foreground at both sites; one used the dimmer icon color. Lowers the no-restyle ceiling from 824 to 812. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
719cb22 to
7f16e83
Compare
|
Superseded by the reworked stack (#12993 v2). After review feedback the layers were rebuilt to add fewer props and take more opinions in the base; see the new stack for the replacement. |
The sidebar thread search and the settings search both rendered an
unstyled Input and then reached into its slot with seven [&_[data-slot=
input]] utilities to make it bare sidebar text. Expose that as
variant="inline". The placeholder now uses sidebar-muted-foreground at
both sites; one used the dimmer icon color.
Lowers the no-restyle ceiling from 824 to 812.
Part of the
components/uiclassName cleanup (audit and guardrail: #12982). Each layer of stack #12993 lowers theshadcn/no-restyleceiling; CI fails if the count rises.Written by Claude Fable 5 in Claude Code.
🤖 Generated with Claude Code
Summary by CodeRabbit