Skip to content

refactor(web): add an inline variant to Input - #13005

Closed
juliusmarminge wants to merge 1 commit into
restyle/button-sizesfrom
restyle/input-inline
Closed

juliusmarminge wants to merge 1 commit into
restyle/button-sizesfrom
restyle/input-inline

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

The sidebar thread search and the settings search both rendered an
unstyled Input and then reached into its slot with seven [&_[data-slot=
input]] utilities to make it bare sidebar text. Expose that as
variant="inline". The placeholder now uses sidebar-muted-foreground at
both sites; one used the dimmer icon color.

Lowers the no-restyle ceiling from 824 to 812.

Part of the components/ui className cleanup (audit and guardrail: #12982). Each layer of stack #12993 lowers the shadcn/no-restyle ceiling; CI fails if the count rises.

Written by Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Style
    • Updated search fields in Settings and the sidebar thread header for a more consistent inline appearance.
    • Simplified search input styling while preserving sizing and flexible layout behavior.
    • Added support for inline-styled inputs with appropriate typography, spacing, and sidebar colors.

@juliusmarminge
juliusmarminge added this pull request to stack #12993 September 22, 2026 05:42
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 22, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 8d8b39d

Macroscope's review found this PR approvable — This is a contained refactor that moves existing sidebar input styling into an explicitly selected inline variant while preserving the component’s default behavior. Its remaining CI change tightens a warning ceiling rather than suppressing diagnostics, so the runtime and review risk are low.

No code changes detected at 7f16e83. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 13.5 KiB — 15.1 KiB ✅
Codex Thread snapshot wire — 7.1 KiB — 7.3 KiB ✅
Codex Live turn WebSocket wire — 6.4 KiB — 7.8 KiB ✅
Codex Live turn WebSocket decoded — 56.3 KiB — 66.4 KiB ✅
Codex Live turn messages — 10 — 21 ✅
Claude Total thread wire — 13.5 KiB — 15.1 KiB ✅
Claude Thread snapshot wire — 7.1 KiB — 7.3 KiB ✅
Claude Live turn WebSocket wire — 6.4 KiB — 7.8 KiB ✅
Claude Live turn WebSocket decoded — 57.0 KiB — 66.4 KiB ✅
Claude Live turn messages — 9 — 21 ✅

Baseline: unavailable · PR result: 7f16e83 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 114.0 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeapp Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

All clear

Posted via Macroscope — UI Consistency

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: cc591836-b48b-4a98-951f-3dce698f9a72

📥 Commits

Reviewing files that changed from the base of the PR and between a75ff29 and 8d8b39d.

📒 Files selected for processing (4)
  • apps/web/src/components/settings/SettingsSidebarNav.tsx
  • apps/web/src/components/sidebar/SidebarThreadHeader.tsx
  • apps/web/src/components/ui/input.tsx
  • scripts/lint-restyle-ceiling.ts

Limit details: You’ve used all 10 included reviews currently available.


📝 Walkthrough

Walkthrough

The shared Input component adds an inline variant. Settings and sidebar search inputs use it with simplified classes. The restyle lint ceiling changes from 824 to 812 findings.

Changes

Inline input styling

Layer / File(s) Summary
Input variant and search consumers
apps/web/src/components/ui/input.tsx, apps/web/src/components/settings/SettingsSidebarNav.tsx, apps/web/src/components/sidebar/SidebarThreadHeader.tsx, scripts/lint-restyle-ceiling.ts
InputProps supports default and inline variants. Inline inputs receive compact typography and sidebar colors. Both search inputs use the inline variant and retain only sizing and flex classes. The lint finding ceiling is lowered to 812.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: stienswout, maria-rcks

Merge Risk: ⚪ Minimal · up to 8d8b3

The sidebar search fields adopt shared inline styling without changing search behavior, and no merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: adding an inline variant to the web Input component.
Description check ✅ Passed The description clearly explains what changed, why the variant was added, the affected search fields, and the restyle ceiling update. It does not use the template headings, include UI screenshots, or …
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

The sidebar thread search and the settings search both rendered an
unstyled Input and then reached into its slot with seven [&_[data-slot=
input]] utilities to make it bare sidebar text. Expose that as
variant="inline". The placeholder now uses sidebar-muted-foreground at
both sites; one used the dimmer icon color.

Lowers the no-restyle ceiling from 824 to 812.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge deleted the branch restyle/button-sizes September 22, 2026 08:04
@juliusmarminge

Copy link
Copy Markdown
Member Author

Superseded by the reworked stack (#12993 v2). After review feedback the layers were rebuilt to add fewer props and take more opinions in the base; see the new stack for the replacement.

@juliusmarminge
juliusmarminge deleted the restyle/input-inline branch September 22, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant