refactor(web): use icon-xs where icon buttons were forced to size-6 - #13004
juliusmarminge wants to merge 1 commit into
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (9)
💤 Files with no reviewable changes (2)
Limit details: You’ve used all 10 included reviews currently available. 📝 WalkthroughWalkthroughThe change removes explicit button size and text classes from web components. Existing size variants and layout classes remain. The restyle lint ceiling decreases from 828 to 824. ChangesUI restyle updates
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to The PR normalizes button sizing without changing button actions or interaction behavior, so it is ready to merge after normal checks. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This is a small, localized button-sizing cleanup with no changes to actions or data flow. It also modifies account and access-management components under the authentication area, which warrants human review under the repository’s safety criteria. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
590ff89 to
139a038
Compare
Three icon-micro/icon-xs buttons overrode themselves to size-6, which is what icon-xs already is on desktop. The account pages also shrank three sm buttons to 13px; they now read at the sm size like every other button. Lowers the no-restyle ceiling from 828 to 824. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
139a038 to
9ecc660
Compare
|
Superseded by the reworked stack (#12993 v2). After review feedback the layers were rebuilt to add fewer props and take more opinions in the base; see the new stack for the replacement. |
Three icon-micro/icon-xs buttons overrode themselves to size-6, which is
what icon-xs already is on desktop. The account pages also shrank three
sm buttons to 13px; they now read at the sm size like every other button.
Lowers the no-restyle ceiling from 828 to 824.
Part of the
components/uiclassName cleanup (audit and guardrail: #12982). Each layer of stack #12993 lowers theshadcn/no-restyleceiling; CI fails if the count rises.Written by Claude Fable 5 in Claude Code.
🤖 Generated with Claude Code
Summary by CodeRabbit
Style
Chores