Skip to content

refactor(web): use icon-xs where icon buttons were forced to size-6 - #13004

Closed
juliusmarminge wants to merge 1 commit into
restyle/sidebar-partsfrom
restyle/button-sizes
Closed

juliusmarminge wants to merge 1 commit into
restyle/sidebar-partsfrom
restyle/button-sizes

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

Three icon-micro/icon-xs buttons overrode themselves to size-6, which is
what icon-xs already is on desktop. The account pages also shrank three
sm buttons to 13px; they now read at the sm size like every other button.

Lowers the no-restyle ceiling from 828 to 824.

Part of the components/ui className cleanup (audit and guardrail: #12982). Each layer of stack #12993 lowers the shadcn/no-restyle ceiling; CI fails if the count rises.

Written by Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Style

    • Standardized sizing and text styling across sidebar, chat, profile, provider status, and pull request controls.
    • Preserved existing button actions, labels, positioning, and focus behavior while removing inconsistent fixed-size styling.
    • Updated queued-message controls and other compact actions to use consistent extra-small icon sizing.
  • Chores

    • Adjusted internal styling validation thresholds to reflect the updated interface styling.

@juliusmarminge
juliusmarminge added this pull request to stack #12993 September 22, 2026 05:42
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 13.5 KiB — 15.1 KiB ✅
Codex Thread snapshot wire — 7.1 KiB — 7.3 KiB ✅
Codex Live turn WebSocket wire — 6.4 KiB — 7.8 KiB ✅
Codex Live turn WebSocket decoded — 56.2 KiB — 66.4 KiB ✅
Codex Live turn messages — 9 — 21 ✅
Claude Total thread wire — 13.5 KiB — 15.1 KiB ✅
Claude Thread snapshot wire — 7.1 KiB — 7.3 KiB ✅
Claude Live turn WebSocket wire — 6.4 KiB — 7.8 KiB ✅
Claude Live turn WebSocket decoded — 57.0 KiB — 66.4 KiB ✅
Claude Live turn messages — 9 — 21 ✅

Baseline: unavailable · PR result: 9ecc660 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 114.0 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: c88976a7-6d0a-4502-a326-a94e3b9f6940

📥 Commits

Reviewing files that changed from the base of the PR and between 6bc23bf and a75ff29.

📒 Files selected for processing (9)
  • apps/web/src/components/LegacySidebar.tsx
  • apps/web/src/components/RightPanelTabs.tsx
  • apps/web/src/components/Sidebar.tsx
  • apps/web/src/components/chat/MessagesTimeline.tsx
  • apps/web/src/components/chat/ProviderStatusBanner.tsx
  • apps/web/src/components/clerk/ClerkUserProfilePage.tsx
  • apps/web/src/components/clerk/T3ConnectUserProfilePage.tsx
  • apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx
  • scripts/lint-restyle-ceiling.ts
💤 Files with no reviewable changes (2)
  • apps/web/src/components/LegacySidebar.tsx
  • apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx

Limit details: You’ve used all 10 included reviews currently available.


📝 Walkthrough

Walkthrough

The change removes explicit button size and text classes from web components. Existing size variants and layout classes remain. The restyle lint ceiling decreases from 828 to 824.

Changes

UI restyle updates

Layer / File(s) Summary
Button sizing normalization
apps/web/src/components/LegacySidebar.tsx, apps/web/src/components/RightPanelTabs.tsx, apps/web/src/components/Sidebar.tsx, apps/web/src/components/chat/*, apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx, scripts/lint-restyle-ceiling.ts
Sidebar, chat, provider status, and pull-request buttons no longer use explicit fixed sizing classes. Chat controls use icon-xs. The restyle finding ceiling changes from 828 to 824.
Clerk button text styling
apps/web/src/components/clerk/ClerkUserProfilePage.tsx, apps/web/src/components/clerk/T3ConnectUserProfilePage.tsx
Clerk profile buttons no longer apply custom text-size classes. Existing actions and states remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Suggested reviewers: stienswout, t3dotgg

Merge Risk: ⚪ Minimal · up to a75ff

The PR normalizes button sizing without changing button actions or interaction behavior, so it is ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 7 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The description explains the main changes and rationale, but it does not use the required section headings, checklist, or before-and-after screenshots for the UI changes. Update the description to include What Changed, Why, UI Changes, and Checklist sections. Add before-and-after screenshots for the UI changes and complete the checklist items.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main change: replacing forced size-6 styling with icon-xs sizing for web icon buttons.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@macroscopeapp

macroscopeapp Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This is a small, localized button-sizing cleanup with no changes to actions or data flow. It also modifies account and access-management components under the authentication area, which warrants human review under the repository’s safety criteria.

No code changes detected at 9ecc660. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge force-pushed the restyle/button-sizes branch 2 times, most recently from 590ff89 to 139a038 Compare September 22, 2026 05:57
Three icon-micro/icon-xs buttons overrode themselves to size-6, which is
what icon-xs already is on desktop. The account pages also shrank three
sm buttons to 13px; they now read at the sm size like every other button.

Lowers the no-restyle ceiling from 828 to 824.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge

Copy link
Copy Markdown
Member Author

Superseded by the reworked stack (#12993 v2). After review feedback the layers were rebuilt to add fewer props and take more opinions in the base; see the new stack for the replacement.

@juliusmarminge
juliusmarminge deleted the restyle/button-sizes branch September 22, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant