Skip to content

chore(lint): exempt CollapsibleTrigger from no-restyle - #13002

Closed
juliusmarminge wants to merge 1 commit into
restyle/kbd-alertfrom
restyle/headless-trigger-contract
Closed

juliusmarminge wants to merge 1 commit into
restyle/kbd-alertfrom
restyle/headless-trigger-contract

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

CollapsibleTrigger is a bare button and a disclosure row is not a Button,
so there is no styled counterpart to render through; all 15 consumers
style it fully and no two share a shape. Its className is the API. Every
other headless trigger has a Button to render, so they stay covered.

Lowers the no-restyle ceiling from 911 to 842.

Part of the components/ui className cleanup (audit and guardrail: #12982). Each layer of stack #12993 lowers the shadcn/no-restyle ceiling; CI fails if the count rises.

Written by Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated styling validation thresholds to reflect the current state of the interface.
    • Expanded the supported styling options for collapsible controls, including layout, color, typography, spacing, shape, effects, and motion.

@juliusmarminge
juliusmarminge added this pull request to stack #12993 September 22, 2026 05:42
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 22, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR changes lint policy by allowing all styling categories for CollapsibleTrigger and adjusting the CI ceiling accordingly. Because it broadens suppression of an existing static-analysis diagnostic, the policy change warrants human review despite having no direct product-runtime impact.

No code changes detected at 86e387a. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 13.5 KiB — 15.1 KiB ✅
Codex Thread snapshot wire — 7.1 KiB — 7.3 KiB ✅
Codex Live turn WebSocket wire — 6.5 KiB — 7.8 KiB ✅
Codex Live turn WebSocket decoded — 56.3 KiB — 66.4 KiB ✅
Codex Live turn messages — 10 — 21 ✅
Claude Total thread wire — 13.5 KiB — 15.1 KiB ✅
Claude Thread snapshot wire — 7.1 KiB — 7.3 KiB ✅
Claude Live turn WebSocket wire — 6.4 KiB — 7.8 KiB ✅
Claude Live turn WebSocket decoded — 57.0 KiB — 66.4 KiB ✅
Claude Live turn messages — 9 — 21 ✅

Baseline: unavailable · PR result: 86e387a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 5ab06ca8-e5e9-46d1-a428-bb4339ce15c6

📥 Commits

Reviewing files that changed from the base of the PR and between 5bba193 and 79c51c7.

📒 Files selected for processing (2)
  • scripts/lint-restyle-ceiling.ts
  • vite.config.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The PR lowers the RESTYLE finding ceiling from 911 to 842 and expands permitted styling classes for CollapsibleTrigger in the web lint configuration.

Changes

RESTYLE lint policy

Layer / File(s) Summary
Lint ceiling and component contract
scripts/lint-restyle-ceiling.ts, vite.config.ts
The RESTYLE ceiling changes to 842 findings. The CollapsibleTrigger lint contract permits layout, color, typography, spacing, shape, effects, and motion classes.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 79c51

This change only expands lint allowances for CollapsibleTrigger and lowers the finding ceiling; no product behavior or runtime path is changed, so it is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: exempting CollapsibleTrigger from the no-restyle lint rule.
Description check ✅ Passed The description explains what changed, why the exemption is needed, and the updated lint ceiling. It does not use the template headings or include the checklist, but it contains the critical change an…
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge
juliusmarminge force-pushed the restyle/headless-trigger-contract branch 2 times, most recently from 0e30fd0 to 8a12bf0 Compare September 22, 2026 05:57
CollapsibleTrigger is a bare button and a disclosure row is not a Button,
so there is no styled counterpart to render through; all 15 consumers
style it fully and no two share a shape. Its className is the API. Every
other headless trigger has a Button to render, so they stay covered.

Lowers the no-restyle ceiling from 911 to 842.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge force-pushed the restyle/headless-trigger-contract branch from 8a12bf0 to 86e387a Compare September 22, 2026 05:58
@juliusmarminge

Copy link
Copy Markdown
Member Author

Superseded by the reworked stack (#12993 v2). After review feedback the layers were rebuilt to add fewer props and take more opinions in the base; see the new stack for the replacement.

@juliusmarminge
juliusmarminge deleted the restyle/headless-trigger-contract branch September 22, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant