chore(lint): exempt CollapsibleTrigger from no-restyle - #13002
juliusmarminge wants to merge 1 commit into
Conversation
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR changes lint policy by allowing all styling categories for No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PR lowers the RESTYLE finding ceiling from 911 to 842 and expands permitted styling classes for ChangesRESTYLE lint policy
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to This change only expands lint allowances for CollapsibleTrigger and lowers the finding ceiling; no product behavior or runtime path is changed, so it is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
0e30fd0 to
8a12bf0
Compare
CollapsibleTrigger is a bare button and a disclosure row is not a Button, so there is no styled counterpart to render through; all 15 consumers style it fully and no two share a shape. Its className is the API. Every other headless trigger has a Button to render, so they stay covered. Lowers the no-restyle ceiling from 911 to 842. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
8a12bf0 to
86e387a
Compare
|
Superseded by the reworked stack (#12993 v2). After review feedback the layers were rebuilt to add fewer props and take more opinions in the base; see the new stack for the replacement. |
CollapsibleTrigger is a bare button and a disclosure row is not a Button,
so there is no styled counterpart to render through; all 15 consumers
style it fully and no two share a shape. Its className is the API. Every
other headless trigger has a Button to render, so they stay covered.
Lowers the no-restyle ceiling from 911 to 842.
Part of the
components/uiclassName cleanup (audit and guardrail: #12982). Each layer of stack #12993 lowers theshadcn/no-restyleceiling; CI fails if the count rises.Written by Claude Fable 5 in Claude Code.
🤖 Generated with Claude Code
Summary by CodeRabbit