refactor(web): add font="mono" to Input, SelectTrigger and SelectItem - #12989
juliusmarminge wants to merge 1 commit into
Conversation
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The changes are primarily a low-risk typography refactor with unchanged defaults and no data-flow changes. Human review is still required because the PR touches the usage/model-price override surface, which is covered by the billing and metering sensitivity rule. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Limit details: You’ve used all 10 included reviews currently available. 📝 WalkthroughWalkthroughThe shared ChangesMonospace font prop migration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The change centralizes monospace styling for form controls and adds numeric alignment; no concrete compatibility or runtime risk is identified, so it is ready to merge with normal checks. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkExplanation The description explains the main change and rationale, but it does not follow the required template. It omits the required checklist and UI screenshots, and it reports the restyle ceiling change as 1105 to 1088 while the changeset shows 1106 to 1089.
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
21cfa3c to
1e4889c
Compare
0fe9883 to
d72792c
Compare
Dismissing prior approval to re-evaluate d72792c
d72792c to
ea1e9c9
Compare
b26f8ed to
4240cf2
Compare
Paths, commands, keybindings, colors and prices all set font-mono (and sometimes tabular-nums) through className on form fields. Expose that as font="mono", which applies both, and migrate the 17 call sites. Only visible change: mono inputs that lacked tabular-nums now have them. Lowers the no-restyle ceiling from 1105 to 1088. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
4240cf2 to
690f14e
Compare
Paths, commands, keybindings, colors and prices all set font-mono (and
sometimes tabular-nums) through className on form fields. Expose that as
font="mono", which applies both, and migrate the 17 call sites. Only
visible change: mono inputs that lacked tabular-nums now have them.
Lowers the no-restyle ceiling from 1105 to 1088.
Part of the
components/uiclassName cleanup (audit and guardrail: #12982). Each layer of stack #12993 lowers theshadcn/no-restyleceiling; CI fails if the count rises.Written by Claude Fable 5 in Claude Code.
🤖 Generated with Claude Code
Summary by CodeRabbit