Skip to content

refactor(web): add font="mono" to Input, SelectTrigger and SelectItem - #12989

Closed
juliusmarminge wants to merge 1 commit into
restyle/small-defaultsfrom
restyle/mono-fields
Closed

juliusmarminge wants to merge 1 commit into
restyle/small-defaultsfrom
restyle/mono-fields

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

Paths, commands, keybindings, colors and prices all set font-mono (and
sometimes tabular-nums) through className on form fields. Expose that as
font="mono", which applies both, and migrate the 17 call sites. Only
visible change: mono inputs that lacked tabular-nums now have them.

Lowers the no-restyle ceiling from 1105 to 1088.

Part of the components/ui className cleanup (audit and guardrail: #12982). Each layer of stack #12993 lowers the shadcn/no-restyle ceiling; CI fails if the count rises.

Written by Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Style
    • Standardized monospace typography for device tools, settings controls, keybindings, color pickers, provider fields, and usage price inputs.
    • Added consistent monospace font options for text inputs, select menus, and selectable menu items.
    • Preserved existing sizing, behavior, and other visual styling while improving consistency across these controls.

@juliusmarminge
juliusmarminge added this pull request to stack #12993 September 22, 2026 04:42
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 22, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 22, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The changes are primarily a low-risk typography refactor with unchanged defaults and no data-flow changes. Human review is still required because the PR touches the usage/model-price override surface, which is covered by the billing and metering sensitivity rule.

No code changes detected at 690f14e. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 13.5 KiB — 15.1 KiB ✅
Codex Thread snapshot wire — 7.1 KiB — 7.3 KiB ✅
Codex Live turn WebSocket wire — 6.4 KiB — 7.8 KiB ✅
Codex Live turn WebSocket decoded — 56.2 KiB — 66.4 KiB ✅
Codex Live turn messages — 9 — 21 ✅
Claude Total thread wire — 13.5 KiB — 15.1 KiB ✅
Claude Thread snapshot wire — 7.1 KiB — 7.3 KiB ✅
Claude Live turn WebSocket wire — 6.4 KiB — 7.8 KiB ✅
Claude Live turn WebSocket decoded — 57.0 KiB — 66.4 KiB ✅
Claude Live turn messages — 9 — 21 ✅

Baseline: unavailable · PR result: 690f14e · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 114.0 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 5680d8dd-0cdb-4eec-92f2-c5bc6611897a

📥 Commits

Reviewing files that changed from the base of the PR and between 0fe9883 and d72792c.

📒 Files selected for processing (1)
  • scripts/lint-restyle-ceiling.ts

Limit details: You’ve used all 10 included reviews currently available.


📝 Walkthrough

Walkthrough

The shared Input and select components now support a font="mono" option. Device, settings, and usage controls use the option instead of monospace utility classes. The restyle lint ceiling is lowered from 1106 to 1089.

Changes

Monospace font prop migration

Layer / File(s) Summary
Add font variants
apps/web/src/components/ui/input.tsx, apps/web/src/components/ui/select.tsx
Input, SelectTrigger, and SelectItem support default and monospace font variants. The monospace variant applies monospace and tabular-number styling.
Migrate monospace controls
apps/web/src/components/device/DeviceToolsPanel.tsx, apps/web/src/components/settings/*, apps/web/src/components/usage/UsagePriceOverrides.tsx, scripts/lint-restyle-ceiling.ts
Existing controls use the font prop instead of monospace utility classes. The lint finding ceiling is lowered to 1089.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to d7279

The change centralizes monospace styling for form controls and adds numeric alignment; no concrete compatibility or runtime risk is identified, so it is ready to merge with normal checks.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 10 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The description explains the main change and rationale, but it does not follow the required template. It omits the required checklist and UI screenshots, and it reports the restyle ceiling change as 1… Add the required What Changed, Why, UI Changes, and Checklist sections. Include before/after screenshots for the UI changes. Correct the restyle ceiling values to 1106 to 1089.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: adding the mono font option to Input, SelectTrigger, and SelectItem.
Full details: Description check

Explanation

The description explains the main change and rationale, but it does not follow the required template. It omits the required checklist and UI screenshots, and it reports the restyle ceiling change as 1105 to 1088 while the changeset shows 1106 to 1089.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge
juliusmarminge force-pushed the restyle/mono-fields branch 2 times, most recently from 0fe9883 to d72792c Compare September 22, 2026 05:11
@macroscopeapp
macroscopeapp Bot dismissed their stale review September 22, 2026 05:11

Dismissing prior approval to re-evaluate d72792c

@juliusmarminge
juliusmarminge force-pushed the restyle/mono-fields branch 2 times, most recently from b26f8ed to 4240cf2 Compare September 22, 2026 05:57
Paths, commands, keybindings, colors and prices all set font-mono (and
sometimes tabular-nums) through className on form fields. Expose that as
font="mono", which applies both, and migrate the 17 call sites. Only
visible change: mono inputs that lacked tabular-nums now have them.

Lowers the no-restyle ceiling from 1105 to 1088.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge deleted the branch restyle/small-defaults September 22, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant