Skip to content

refactor(web): use ghost-muted where ghost buttons restyled to muted - #12987

Closed
juliusmarminge wants to merge 1 commit into
restyle/tooltip-widthfrom
restyle/button-muted-tone
Closed

juliusmarminge wants to merge 1 commit into
restyle/tooltip-widthfrom
restyle/button-muted-tone

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

Fourteen ghost buttons re-declared text-muted-foreground and
hover:text-foreground through className. That combination is exactly the
ghost-muted variant (same icon tint, same hover surface), so swap them over
and drop the classes. No rendered change.

Lowers the no-restyle ceiling from 1146 to 1124.

Part of the components/ui className cleanup (audit and guardrail: #12982). Each layer of stack #12993 lowers the shadcn/no-restyle ceiling; CI fails if the count rises.

Written by Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Style

    • Standardized muted action buttons across comments, pull requests, settings, provider status, and navigation menus for a more consistent appearance.
    • Preserved existing button sizing and interaction behavior.
  • Bug Fixes

    • Long titles in dialogs and alert dialogs now wrap instead of overflowing.
  • Chores

    • Updated interface styling consistency checks to reflect the latest standardized button appearance.

@juliusmarminge
juliusmarminge added this pull request to stack #12993 September 22, 2026 04:42
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 13.5 KiB — 15.1 KiB ✅
Codex Thread snapshot wire — 7.1 KiB — 7.3 KiB ✅
Codex Live turn WebSocket wire — 6.4 KiB — 7.8 KiB ✅
Codex Live turn WebSocket decoded — 56.2 KiB — 66.4 KiB ✅
Codex Live turn messages — 9 — 21 ✅
Claude Total thread wire — 13.5 KiB — 15.1 KiB ✅
Claude Thread snapshot wire — 7.1 KiB — 7.3 KiB ✅
Claude Live turn WebSocket wire — 6.5 KiB — 7.8 KiB ✅
Claude Live turn WebSocket decoded — 57.0 KiB — 66.4 KiB ✅
Claude Live turn messages — 9 — 21 ✅

Baseline: unavailable · PR result: 3b052cd · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 22, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 13045f2

Macroscope's review found this PR approvable — This is a contained web styling refactor that consolidates existing muted ghost-button styling into an established variant without changing handlers, APIs, schemas, or workflows. The accompanying lint-threshold update tightens CI enforcement rather than suppressing diagnostics.

No code changes detected at 3b052cd. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 7370d8b0-b89e-427a-a166-c6ff2abbed5d

📥 Commits

Reviewing files that changed from the base of the PR and between 3e91c7a and 13045f2.

📒 Files selected for processing (1)
  • scripts/lint-restyle-ceiling.ts

Limit details: You’ve used all 10 included reviews currently available.


📝 Walkthrough

Walkthrough

The change updates button styling across web components to use ghost-muted and lowers the restyle lint finding ceiling from 1147 to 1125.

Changes

Muted button restyle

Layer / File(s) Summary
Button variant migration
apps/web/src/components/DiffFilePathCopyButton.tsx, apps/web/src/components/RightPanelTabs.tsx, apps/web/src/components/chat/ProviderStatusBanner.tsx, apps/web/src/components/diffs/DiffCommentAnnotation.tsx, apps/web/src/components/pullRequest/*, apps/web/src/components/settings/*
Updated affected buttons from ghost to ghost-muted and removed redundant explicit muted text and hover color classes.
Restyle lint ceiling
scripts/lint-restyle-ceiling.ts
Lowered RESTYLE_CEILING from 1147 to 1125.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 13045

This styling refactor adopts the shared ghost-muted button variant without an identified production impact, and is ready to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 12 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the primary change: replacing manually restyled ghost buttons with the ghost-muted variant.
Description check ✅ Passed The description explains the change, the reason for it, the intended lack of rendered impact, and the restyle-ceiling update. It does not use the template headings, include the checklist, or provide U…
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge
juliusmarminge force-pushed the restyle/button-muted-tone branch from 7e8b831 to 2c4a673 Compare September 22, 2026 04:50
@juliusmarminge
juliusmarminge force-pushed the restyle/button-muted-tone branch from 2c4a673 to 3e91c7a Compare September 22, 2026 04:56
@juliusmarminge
juliusmarminge force-pushed the restyle/button-muted-tone branch from 3e91c7a to 13045f2 Compare September 22, 2026 05:11
@macroscopeapp
macroscopeapp Bot dismissed their stale review September 22, 2026 05:11

Dismissing prior approval to re-evaluate 13045f2

@juliusmarminge
juliusmarminge force-pushed the restyle/button-muted-tone branch 2 times, most recently from b505771 to cde16d7 Compare September 22, 2026 05:18
@macroscopeapp

This comment has been minimized.

@juliusmarminge
juliusmarminge force-pushed the restyle/button-muted-tone branch from cde16d7 to ed81f1b Compare September 22, 2026 05:57
Fourteen ghost buttons re-declared text-muted-foreground and
hover:text-foreground through className. That combination is exactly the
ghost-muted variant (same icon tint, same hover surface), so swap them over
and drop the classes. No rendered change.

Lowers the no-restyle ceiling from 1146 to 1124.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge force-pushed the restyle/button-muted-tone branch from ed81f1b to 3b052cd Compare September 22, 2026 05:58
@juliusmarminge
juliusmarminge deleted the branch restyle/tooltip-width September 22, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant