refactor(web): use ghost-muted where ghost buttons restyled to muted - #12987
juliusmarminge wants to merge 1 commit into
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a contained web styling refactor that consolidates existing muted ghost-button styling into an established variant without changing handlers, APIs, schemas, or workflows. The accompanying lint-threshold update tightens CI enforcement rather than suppressing diagnostics. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Limit details: You’ve used all 10 included reviews currently available. 📝 WalkthroughWalkthroughThe change updates button styling across web components to use ChangesMuted button restyle
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to This styling refactor adopts the shared ghost-muted button variant without an identified production impact, and is ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
7e8b831 to
2c4a673
Compare
2c4a673 to
3e91c7a
Compare
3e91c7a to
13045f2
Compare
Dismissing prior approval to re-evaluate 13045f2
b505771 to
cde16d7
Compare
This comment has been minimized.
This comment has been minimized.
cde16d7 to
ed81f1b
Compare
Fourteen ghost buttons re-declared text-muted-foreground and hover:text-foreground through className. That combination is exactly the ghost-muted variant (same icon tint, same hover surface), so swap them over and drop the classes. No rendered change. Lowers the no-restyle ceiling from 1146 to 1124. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ed81f1b to
3b052cd
Compare
Fourteen ghost buttons re-declared text-muted-foreground and
hover:text-foreground through className. That combination is exactly the
ghost-muted variant (same icon tint, same hover surface), so swap them over
and drop the classes. No rendered change.
Lowers the no-restyle ceiling from 1146 to 1124.
Part of the
components/uiclassName cleanup (audit and guardrail: #12982). Each layer of stack #12993 lowers theshadcn/no-restyleceiling; CI fails if the count rises.Written by Claude Fable 5 in Claude Code.
🤖 Generated with Claude Code
Summary by CodeRabbit
Style
Bug Fixes
Chores