fix(server): start ACP MCP bridge in self-contained runtime - #12747
juliusmarminge merged 2 commits into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped ACP MCP bridge startup fix that preserves existing script-based launches and changes only the self-contained runtime argument vector. The production change is small, isolated, and covered by a focused regression test. You can add or adjust custom eligibility rules. Learn more. |
a1f8051 to
0337dd6
Compare
|
Verification update The failure is in T3 Code's ACP bridge launch arguments. When the server entrypoint resolves to The existing patch was locally rebased onto
The previously recorded isolated Antigravity execution returned The rebase is not published yet: this PR still points to Verification update by GPT-6 in the T3 Code Codex harness; the tests and build above were run by GPT-5.6 Sol in the preceding turn. |
…ACP bridge Path equality between execPath and argv[1] is an accident of how Node fixes up argv for a single-executable, not the signal. Ask node:sea directly, leave T3_ACP_MCP_ENTRYPOINT unset in that runtime, and teach the terminal fallback instruction to omit the entrypoint when the variable is missing, so agents running under the packaged binary can still reach acp-mcp-call. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
95dd67d to
ef80d2e
Compare
|
Rebased onto v2 and pushed one follow-up commit on top of yours (ef80d2e):
Verified locally: |
953e94a
into
pingdotgg:t3code/codex-turn-mapping
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
What changed
The ACP adapter now omits the duplicated server entrypoint when the T3 executable is itself the self-contained runtime. Script-based Node and Electron launches keep the existing command vector. A focused adapter regression covers the self-contained path.
Why
Antigravity could not initialize the injected t3-code MCP server because the self-contained runtime parsed its own executable path as an ordinary CLI positional argument. The bridge process closed before MCP initialize completed.
Verification
Model(s): GPT-5.6 Sol, GPT-5.6 Luna, Gemini 3.8 Flash Medium
Harness: T3 Code Codex harness and T3 Code Orchestrator V2