fix(server): send Codex browser guidance as application context - #12739
riccardopll wants to merge 1 commit into
Conversation
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This changes Codex’s automatic browser-tool guidance and default tool-selection behavior by moving existing instructions into application context and applying them on browser-enabled turns. The implementation is focused and tested, but the behavior change affects the default runtime path and warrants human review. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe change separates browser instructions from device instructions. Turn-start parameters now provide browser guidance through ChangesBrowser context delivery
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant Caller
participant buildTurnStartParams
participant buildCodexBrowserInstructions
Caller->>buildTurnStartParams: provide browserToolsAvailable
buildTurnStartParams->>buildCodexBrowserInstructions: generate browser instructions
buildCodexBrowserInstructions-->>buildTurnStartParams: return instructions
buildTurnStartParams-->>Caller: return additionalContext.t3_browser
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Superseded by merged #13547, which moves Codex browser/device tool guidance (along with runtime info and PR linking) out of collaboration-mode Closing this PR as superseded. Please reopen if anything unique here is still needed beyond #13547. |
What Changed
Move the existing Codex browser guidance from collaboration-mode instructions into keyed application context. Keep the wording and preview-tool availability gate unchanged.
Why
Codex can choose bundled Computer Use despite T3’s browser guidance. Presenting that guidance separately improved tool selection without appending it to each user message. This is a workaround, ideally Codex should not assume that no integrated browser is available when the bundled Computer Use plugin is inactive.
Refs #11579.
Validation
30 fresh-session live-model trials, using five browser tasks, a mock T3 MCP endpoint, and bundled Computer Use:
preview_statusdispatch: 5/5.These verify tool selection and dispatch, not rendering. A separate request-capture check found one browser-rule copy across four turns, including a mode change; restarting Codex adds another copy.
All 50 focused runtime tests, targeted lint/format checks, and server typecheck passed.
Checklist
Implemented with GPT-6 in Codex; live tests used gpt-6-astra (medium reasoning) through Codex app-server 0.155.1.
Summary by CodeRabbit