Conversation
…oomed preview_resize compared guest innerWidth to the declared CSS size. A zoomed app window made the guest report innerWidth × windowZoom, so the wait never succeeded and the automation host was evicted. Guest zoom is now tab.zoomFactor × the main window zoom factor; stored preview zoom stays unchanged. Co-authored-by: maco <macodev00@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughPreview guests now use the product of their preview zoom and the main window zoom. Invalid or unavailable window zoom values fall back to ChangesPreview guest zoom alignment
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
|
|
@coderabbitai review |
|
What
tab.zoomFactor × mainWindow zoomsopreview_resizematches CSS size when the main window is zoomed.Why
Fixes #12319
The guest was reset to preview-only zoom while Chromium multiplies layout by main-window zoom, so a 1280×800 request reported ~2019×1262 and the wait always timed out (evicting the automation host).
UI
N/A for product chrome — preview automation resize succeeds while View → Zoom is above 100%.
Checklist
Summary by CodeRabbit
Bug Fixes
Tests