fix(server): clear Gemini Monitoring when turn finishes by macodev00 · Pull Request #12715 · pingdotgg/t3code

macodev00 · 2026-09-20T09:01:51Z

What

Stop promoting leftover Antigravity execute tools to local_bash on turn settle, so the Monitoring pill clears when a Gemini turn finishes.

Why

Gemini often returns end_turn while execute tools stay inProgress and never sends a later completion. Those were emitted as task.started (local_bash), which pinned backgroundLiveness === "monitoring" until session teardown.

UI

Monitoring status should clear when the Gemini task completes (no new chrome).

Checklist

I read CONTRIBUTING.md and kept this small / bug-only
What + why explained above
Followed AGENTS.md documentation rules (no new docs)
No unrelated changes
CLA / AI-reviewed standing override for macodev00 auto-contrib

Summary by CodeRabbit

Bug Fixes
- Improved handling of execute tools that remain in progress when a turn ends.
- Prevented unfinished background commands from appearing as active local tasks.
- Ensured monitoring state clears when a turn completes while preserving later native completion updates.
- Avoided misleading task-start and completion events for commands that remain open.
Documentation
- Clarified behavior for execute tools that remain in progress after a turn ends.

Gemini often returns end_turn while execute tools remain inProgress and never sends a later completion. Promoting those commands as local_bash left the Monitoring pill up until session teardown. Stop promoting leftover execute tools when the turn settles so Monitoring clears with the finished task. Fixes pingdotgg#12325 Co-authored-by: maco <macodev00@users.noreply.github.com>

coderabbitai · 2026-09-20T09:26:19Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: a1f99a62-38b3-46a7-8cd7-e70a54887110

📥 Commits

Reviewing files that changed from the base of the PR and between f56a566 and 230fd00.

📒 Files selected for processing (3)

apps/server/src/provider/Layers/AntigravityAdapter.test.ts
apps/server/src/provider/Layers/AntigravityAdapter.ts
apps/server/src/provider/acp/AntigravityProtocol.ts

🚧 Files skipped from review as they are similar to previous changes (2)

apps/server/src/provider/acp/AntigravityProtocol.ts
apps/server/src/provider/Layers/AntigravityAdapter.ts

Limit details: You’ve used all 10 included reviews currently available.

📝 Walkthrough

Walkthrough

The Antigravity adapter no longer promotes unfinished execute tools to local_bash tasks when a turn ends. The adapter also extracts generator implementations for sendTurn and factory construction. The monitoring test keeps the same assertions.

Changes

Antigravity monitoring lifecycle

Layer / File(s)	Summary
Turn completion handling `apps/server/src/provider/Layers/AntigravityAdapter.ts`, `apps/server/src/provider/acp/AntigravityProtocol.ts`	Turn completion no longer promotes unfinished execute tools to `local_bash` tasks. Existing settlement and native completion behavior remain. Protocol comments clarify related tool-call behavior.
Adapter effect structure `apps/server/src/provider/Layers/AntigravityAdapter.ts`	`sendTurn` and adapter construction use standalone generator functions wrapped with named `Effect.fn` calls. Comments document client file operations and turn behavior.
Monitoring regression test `apps/server/src/provider/Layers/AntigravityAdapter.test.ts`	The monitoring test delegates its effect body to `assertMonitoringClearsOnEndTurn`. Its task-event and native completion assertions remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: juliusmarminge

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The changes address issue `#12325`. `sendTurn` no longer promotes unfinished Antigravity `execute` commands to `local_bash` tasks after `end_turn`. This allows Monitoring to clear when the turn finishes…
Out of Scope Changes check	✅ Passed	The changes stay within issue `#12325`. The production change fixes turn settlement. The test refactoring preserves the Monitoring regression coverage. The added comments document the Antigravity adapte…
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 3 files.
Title check	✅ Passed	The title clearly identifies the main bug fix: clearing Gemini Monitoring when the turn finishes.
Description check	✅ Passed	The description explains what changed, why it changed, the UI impact, and checklist status. It is focused and provides the linked issue context.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

_{Comment @coderabbitai help to get the list of available commands.}

Document sendTurn, finishTurn, and isAntigravityOpenCommand so leftover execute tools are recorded as staying unpromoted when a Gemini turn ends. Co-authored-by: maco <macodev00@users.noreply.github.com>

Document the end_turn execute-tool case so touched functions in the adapter test file are covered too. Co-authored-by: maco <macodev00@users.noreply.github.com>

CodeRabbit counts FunctionDeclarations. Extract sendTurnEffect and settleTurn so leftover execute-tool settlement is documented. Co-authored-by: maco <macodev00@users.noreply.github.com>

Extract makeAntigravityAdapterEffect and the Monitoring regression test so JSDoc attaches to FunctionDeclarations. Co-authored-by: maco <macodev00@users.noreply.github.com>

Give the end_turn execute-tool fixture a documented generator so the test callback is not an anonymous function*. Co-authored-by: maco <macodev00@users.noreply.github.com>

Add JSDoc on the protocol helper in the diff hunk and on writeClientTextFile next to the adapter factory extract. Co-authored-by: maco <macodev00@users.noreply.github.com>

Keep JSDoc on makeAntigravityAdapter, sendTurn, and interruptTurn so the Effect.fn wrappers are documented as well as the helpers. Co-authored-by: maco <macodev00@users.noreply.github.com>

Attach a single-line JSDoc to every function the Gemini Monitoring diff touches, including the adapter export, so coverage can reach 80%. Co-authored-by: maco <macodev00@users.noreply.github.com>

macodev00 · 2026-09-20T10:07:18Z

@coderabbitai review

coderabbitai · 2026-09-20T10:07:25Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

macodev00 · 2026-09-21T06:28:12Z

@coderabbitai review

coderabbitai · 2026-09-21T06:28:19Z

⚠️ Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

macodev00 · 2026-09-22T06:07:21Z

@coderabbitai review

coderabbitai · 2026-09-22T06:07:27Z

⚠️ Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

juliusmarminge · 2026-09-24T19:22:31Z

Superseded by #13388, which fixed #12325 by letting Stop end Antigravity commands that outlived their turn (instead of stopping promotion of leftover execute tools). Closing this PR as leftover hygiene.

juliusmarminge · 2026-09-24T19:22:33Z

Closing as superseded by #13388 (fixes #12325).

github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 20, 2026

macodev00 marked this pull request as ready for review September 20, 2026 09:20

macodev00 and others added 8 commits September 20, 2026 09:32

docs(antigravity): add JSDoc for turn settlement

a7db489

Document sendTurn, finishTurn, and isAntigravityOpenCommand so leftover execute tools are recorded as staying unpromoted when a Gemini turn ends. Co-authored-by: maco <macodev00@users.noreply.github.com>

docs(antigravity): add JSDoc on Monitoring regression test

8bdd5cd

Document the end_turn execute-tool case so touched functions in the adapter test file are covered too. Co-authored-by: maco <macodev00@users.noreply.github.com>

docs(antigravity): attach JSDoc to named sendTurn helpers

28c23ee

CodeRabbit counts FunctionDeclarations. Extract sendTurnEffect and settleTurn so leftover execute-tool settlement is documented. Co-authored-by: maco <macodev00@users.noreply.github.com>

docs(antigravity): document named adapter and test helpers

f56a566

Extract makeAntigravityAdapterEffect and the Monitoring regression test so JSDoc attaches to FunctionDeclarations. Co-authored-by: maco <macodev00@users.noreply.github.com>

docs(antigravity): name the Monitoring regression generator

161cd9d

Give the end_turn execute-tool fixture a documented generator so the test callback is not an anonymous function*. Co-authored-by: maco <macodev00@users.noreply.github.com>

docs(antigravity): document normalizeAntigravityToolCall

705f1d2

Add JSDoc on the protocol helper in the diff hunk and on writeClientTextFile next to the adapter factory extract. Co-authored-by: maco <macodev00@users.noreply.github.com>

docs(antigravity): restore JSDoc on exported adapter factory

cbe2510

Keep JSDoc on makeAntigravityAdapter, sendTurn, and interruptTurn so the Effect.fn wrappers are documented as well as the helpers. Co-authored-by: maco <macodev00@users.noreply.github.com>

docs(antigravity): use one-line JSDoc on Monitoring helpers

230fd00

Attach a single-line JSDoc to every function the Gemini Monitoring diff touches, including the adapter export, so coverage can reach 80%. Co-authored-by: maco <macodev00@users.noreply.github.com>

juliusmarminge mentioned this pull request Sep 24, 2026

fix(antigravity): let Stop end commands that outlived their turn #13388

Merged

juliusmarminge closed this Sep 24, 2026

Navigation Menu

fix(server): clear Gemini Monitoring when turn finishes - #12715

fix(server): clear Gemini Monitoring when turn finishes#12715
macodev00 wants to merge 9 commits into
pingdotgg:mainfrom
macodev00:cursor/fix-gemini-monitoring-507e

macodev00 commented Sep 20, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 20, 2026 •

edited

Loading

Reviews paused

Walkthrough

Changes

Uh oh!

macodev00 commented Sep 20, 2026

Uh oh!

coderabbitai Bot commented Sep 20, 2026 •

edited

Loading

Uh oh!

macodev00 commented Sep 21, 2026

Uh oh!

coderabbitai Bot commented Sep 21, 2026 •

edited

Loading

Uh oh!

macodev00 commented Sep 22, 2026

Uh oh!

coderabbitai Bot commented Sep 22, 2026 •

edited

Loading

Uh oh!

juliusmarminge commented Sep 24, 2026

Uh oh!

juliusmarminge commented Sep 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

macodev00 commented Sep 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

UI

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Uh oh!

macodev00 commented Sep 20, 2026

Uh oh!

coderabbitai Bot commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

macodev00 commented Sep 21, 2026

Uh oh!

coderabbitai Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

macodev00 commented Sep 22, 2026

Uh oh!

coderabbitai Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juliusmarminge commented Sep 24, 2026

Uh oh!

juliusmarminge commented Sep 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

macodev00 commented Sep 20, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 20, 2026 •

edited

Loading

coderabbitai Bot commented Sep 20, 2026 •

edited

Loading

coderabbitai Bot commented Sep 21, 2026 •

edited

Loading

coderabbitai Bot commented Sep 22, 2026 •

edited

Loading