Skip to content

fix(web): close Run-on picker after selecting a machine - #12713

Closed
macodev00 wants to merge 1 commit into
pingdotgg:mainfrom
macodev00:cursor/close-env-picker-4beb
Closed

macodev00 wants to merge 1 commit into
pingdotgg:mainfrom
macodev00:cursor/close-env-picker-4beb

Conversation

@macodev00

@macodev00 macodev00 commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

What

  • Close the compact Run on environment picker when a machine (or workspace mode) is selected.

Why

Fixes #12684

Base UI MenuRadioItem defaults closeOnClick to false, so the selection applied but the popover stayed open. Same fix pattern as the traits picker.

UI

N/A for motion video — one-line interaction: pick closes menu. No screenshots of unrelated chrome.

Checklist

  • I read CONTRIBUTING.md and kept this small / bug-only
  • What + why explained above
  • Followed AGENTS.md documentation rules (no new docs)
  • No unrelated changes
  • CLA / AI-reviewed standing override for macodev00 auto-contrib

Summary by CodeRabbit

  • Bug Fixes
    • Mobile run and workspace selection menus now close immediately after choosing an option.

Picking a machine in the combined Run on / Workspace menu applied the
change but left the popover open. Base UI radio items default closeOnClick
to false; pass closeOnClick so a pick dismisses the menu, matching the
model and traits pickers.
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 20, 2026
@macodev00
macodev00 marked this pull request as ready for review September 20, 2026 09:20
@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 5b8e1dd1-5a4e-4b19-826c-49ea38b85135

📥 Commits

Reviewing files that changed from the base of the PR and between 7445aa7 and d0eaee8.

📒 Files selected for processing (1)
  • apps/web/src/components/BranchToolbar.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The mobile run context selector now closes when users select a run environment or workspace option.

Changes

Mobile run context selection

Layer / File(s) Summary
Close menu after selection
apps/web/src/components/BranchToolbar.tsx
The “Run on” and “Workspace” radio items now pass closeOnClick.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: t3dotgg

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary fix: closing the Run on picker after selecting a machine.
Description check ✅ Passed The description explains what changed, why it changed, the linked issue, and the focused scope. The UI section does not include screenshots or a video, although the template requests them for interact…
Linked Issues check ✅ Passed The change addresses #12684 in apps/web/src/components/BranchToolbar.tsx. It adds closeOnClick to the MobileRunContextSelector radio items for both the Run on machine choices and the Workspace c…
Out of Scope Changes check ✅ Passed The summary shows only five additions and three removals in apps/web/src/components/BranchToolbar.tsx. All changes add close-on-click behavior to the Run on and Workspace picker options. No unrelate…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge

Copy link
Copy Markdown
Member

Superseded by #12685, which already merged and fixed #12684. Closing this as leftover hygiene.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Environment picker ("Run on") stays open after selecting a machine

2 participants