fix(web): keep composer controls visible when they fit - #12554
maria-rcks wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
All clear
Posted via Macroscope — UI Consistency
This comment has been minimized.
This comment has been minimized.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe composer replaces fixed-width compactness breakpoints with natural-width measurement. It observes control and form size changes, re-measures after font loading, and applies compact visibility and inertness to resting controls. ChangesComposer compactness
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a self-contained composer UI bug fix that replaces fixed thresholds with measured available space, preserving the existing overflow fallback when controls do not fit. Its runtime impact is limited to responsive control visibility, layout, and transitions within the web composer. You can add or adjust custom eligibility rules. Learn more. |
|
Superseded by the shared row work; closing from speed mode. |
Composer reasoning and permission controls disappeared at fixed width thresholds even when they had room. Measure the controls against the space left beside the send/stop actions, retaining the existing overflow menu when they do not fit.
Validation: web typecheck, targeted lint, and 39 existing composer layout/measurement tests passed on Blacksmith. Browser rendering is unverified; Maria waived screenshots and browser verification after the preview host was unavailable.
Model: gpt-6-astra. Harness: Codex.
Summary by CodeRabbit
Bug Fixes
UI Improvements