fix(preview): restore v2 sizing and project access - #12548
juliusmarminge merged 1 commit into
Conversation
There was a problem hiding this comment.
All clear
Posted via Macroscope — UI Consistency
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The UI portion restores workspace-aware, per-thread preview sizing with focused coverage. The server portion changes the authorization boundary for preview-tab controls by relying on project-aware credential capabilities, so the resulting access behavior warrants human review. You can add or adjust custom eligibility rules. Learn more. |
f180e95
into
t3code/codex-turn-mapping
The v2 branch lifted preview sizing into ChatView without the row measurement or per-thread storage key. A saved 800px panel in a 1024px workspace left only 224px for chat, and resizing one thread changed the width used by others. The preview list/close tools rejected a project's browser-access opt-in when the global setting was off.
This follow-up to #2829 reuses ChatView's existing row measurement and restores the scoped thread width key. The list/close handlers now use the project-aware preview capability issued with the credential, matching the other preview tools. A credential without that capability still cannot list or close tabs.
Validation
capability_deniedand passes with this fix; opt-out remains denied and leaves the tab open.Review status
CI passed on
71ee9a3b8b53. Macroscope correctness, Effect conventions, and UI consistency checks passed with no actionable findings. Its approvability check is neutral and requests human review of the project-aware browser access change. CodeRabbit skipped review because this base branch is disabled in its configuration. No review threads are unresolved.Evidence
Matching 1280×900 captures from parent
fd8ea2fb2dd6and this change, with a 1024px workspace and the same saved 800px panel width. The Files surface exercises the shared preview panel shell in the web client; Electron browser automation itself was not re-tested by this pass. The backend tests cover the actual list/close handlers and preview manager.Thread width restoration and sidebar resize recording
Model: GPT-6. Harness: Codex.