chore(deps): pin vulnerable transitive dependencies to patched versions - #12413
juliusmarminge wants to merge 1 commit into
Conversation
Enabling Dependabot alerts surfaced ~135 advisories against pnpm-lock.yaml, almost all in transitive dependencies of build tooling (electron-builder, alchemy, @clerk/expo, the Claude Agent SDK's MCP dependency). None of the parents have shipped a release that lifts the floors yet, so this adds major-scoped overrides in pnpm-workspace.yaml for each affected package. Every override key is scoped to the major the dependents already declare, so no edge crosses a breaking version. pnpm audit drops from 137 advisories to 13; the remainder are astro/sharp (Dependabot #12411), image-size@1 under metro, uuid@7 under xcode, decode-uri-component@0.2 under query-string, and xml2js@0.4 under dbus-next, none of which have an in-major patched release. Made with Claude Fable 5 via Claude Code in T3 Code. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR updates a broad set of transitive dependencies, including packages used by existing server and network paths, through workspace overrides and lockfile rewrites. Its explicit security scope and cross-cutting runtime dependency impact warrant explicit human review. You can add or adjust custom eligibility rules. Learn more. |
268fdb2 to
8a78aa4
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe workspace configuration adds scoped pnpm overrides for vulnerable transitive dependencies. Each override pins a package to a specified security version within its declared major-version line. ChangesDependency Security Floors
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The dependency security-floor changes have no identified merge-blocking risk and are mergeable with normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
Superseded by #12417, which bumps the parent dependencies instead of pinning transitives. |
Enabling Dependabot alerts on the repo surfaced ~135 advisories against
pnpm-lock.yaml. Nearly all of them are transitive dependencies of build tooling (electron-builder,alchemy,@clerk/expo, and the Claude Agent SDK's MCP dependency) whose parents have not yet shipped a release lifting the floor.This adds a block of
overridesinpnpm-workspace.yamlpinning each affected package to its patched release. Every key is scoped to the major the dependents already declare ("tar@7","brace-expansion@1"/"@2"/"@5", …) so no edge is forced across a breaking version —undici@8under@effect/platform-node,path-to-regexp@8underrouter, andundici@6undernode-gypare all left where they were.On top of #12411 (already merged),
pnpm auditgoes from 122 advisories to 5 (2 high / 3 moderate). What remains has no patched release within the declared major and needs the parent to move:image-size@1(metro)uuid@7(xcode)decode-uri-component@0.2(query-string)xml2js@0.4(dbus-next)Verified with
vp run typecheckinapps/server,apps/desktop, andinfra/relay, plusvp test runfor the relay suite and the server's Claude-related tests.Made with Claude Fable 5 via Claude Code in T3 Code.
🤖 Generated with Claude Code
Summary by CodeRabbit