fix(web): edit automations from thread details - #12408
juliusmarminge merged 1 commit into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Adds a localized pencil action that routes each thread automation to the existing scheduled-task editor, while leaving task execution, pause/resume behavior, data contracts, and server code unchanged. The only other change is tooltip wording, making the runtime impact small and self-contained. You can add or adjust custom eligibility rules. Learn more. |
a1f8051 to
0337dd6
Compare
c31b8df to
33048ab
Compare
| <Button | ||
| size="icon-xs" | ||
| variant="ghost" | ||
| className={THREAD_DETAILS_PANEL_ICON_ACTION_CLASS} |
There was a problem hiding this comment.
Shared primitives over custom controls: THREAD_DETAILS_PANEL_ICON_ACTION_CLASS overrides Button sizing, radius, padding, and base colors. Please move this treatment into a Button size/variant and use that here.
Suggested fix: No diff — this requires adding or extending the shared Button API.
Posted via Macroscope — UI Consistency
9d6feae
into
pingdotgg:t3code/codex-turn-mapping
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
What Changed
Each automation in thread details now has a visible pencil button. It opens that automation's existing editor so users can change its prompt or schedule, with the owning environment selected.
This changes the shared web/desktop panel. Mobile, provider adapters, the server, and wire contracts are unchanged.
Why
Automation rows offered Run and Pause but no direct editing entry point. Reusing the scheduled-task editor keeps editing consistent with Settings.
The OV2 base already includes #12351, which fixes the separate missing-list issue by opening scheduled tasks in the thread's environment. This PR adds the row-level editing action on top of that fix.
Verification
vp test run src/components/settings/settingsScopeNavigation.test.ts src/components/settings/scheduledTasksSettings.logic.test.ts --project unitinapps/web: 35 passed.git diff --check: passed.vp run typecheckinapps/web: passed, with existing Effect suggestions in unrelated files.UI Changes
Captured with the same synthetic, paused Documentation reminder fixture, dark theme, and 1720 × 1274 viewport. Base:
73bbe82386384a11730875be57534fa7c66b4d72. Candidate:c31b8df80a3bfde60f68ca90e7e3eba15359b1c9.Before and after: the automation row gains a visible edit button. This GIF alternates labeled still captures.
The pencil opens the editor; changing the prompt and interval then saving returns to the task list.
Editor detail, cropped from the same recording, showing the changed prompt and 10-minute interval:
The interaction GIFs use actual browser screencast frames reconstructed at 10 fps. The 8-second full clip joins opening and saving with the idle gap removed, then holds the saved task list before the separate reload check. The detail excerpt holds its final frame. These demonstrate the interaction, with no timing or smoothness claim.
automation-edit-final.mp4
Saved values after reloading the editor
Checklist
Implementation used GPT-6 Astra in Codex through T3 Code.