Skip to content

fix(web): edit automations from thread details - #12408

Merged
juliusmarminge merged 1 commit into
pingdotgg:t3code/codex-turn-mappingfrom
saphid:agent/web-automation-edit-ov2
Sep 21, 2026
Merged

juliusmarminge merged 1 commit into
pingdotgg:t3code/codex-turn-mappingfrom
saphid:agent/web-automation-edit-ov2

Conversation

@saphid

@saphid saphid commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

What Changed

Each automation in thread details now has a visible pencil button. It opens that automation's existing editor so users can change its prompt or schedule, with the owning environment selected.

This changes the shared web/desktop panel. Mobile, provider adapters, the server, and wire contracts are unchanged.

Why

Automation rows offered Run and Pause but no direct editing entry point. Reusing the scheduled-task editor keeps editing consistent with Settings.

The OV2 base already includes #12351, which fixes the separate missing-list issue by opening scheduled tasks in the thread's environment. This PR adds the row-level editing action on top of that fix.

Verification

  • vp test run src/components/settings/settingsScopeNavigation.test.ts src/components/settings/scheduledTasksSettings.logic.test.ts --project unit in apps/web: 35 passed.
  • Targeted lint, formatting, and git diff --check: passed.
  • vp run typecheck in apps/web: passed, with existing Effect suggestions in unrelated files.
  • Chrome on macOS, isolated local server: the base's Manage action lists the fixture automation. The candidate's pencil opens the correct task and environment. Changed its prompt and interval from 5 to 10 minutes, saved, checked the database values, and reloaded the editor to confirm persistence. Returning to the thread shows Every 10 min. One reload wait timed out during dev loading; the following DOM inspection confirmed the saved values.
  • Desktop shell, mobile, and a separate remote connection were not exercised. Independent Fable review was attempted but unavailable because Claude authentication failed.

UI Changes

Captured with the same synthetic, paused Documentation reminder fixture, dark theme, and 1720 × 1274 viewport. Base: 73bbe82386384a11730875be57534fa7c66b4d72. Candidate: c31b8df80a3bfde60f68ca90e7e3eba15359b1c9.

Before and after: the automation row gains a visible edit button. This GIF alternates labeled still captures.

Before and after: automation row gains a pencil button

The pencil opens the editor; changing the prompt and interval then saving returns to the task list.

Open the automation editor, change prompt and interval, and save

Editor detail, cropped from the same recording, showing the changed prompt and 10-minute interval:

Editor detail: prompt and interval changes

The interaction GIFs use actual browser screencast frames reconstructed at 10 fps. The 8-second full clip joins opening and saving with the idle gap removed, then holds the saved task list before the separate reload check. The detail excerpt holds its final frame. These demonstrate the interaction, with no timing or smoothness claim.

automation-edit-final.mp4
Saved values after reloading the editor

Reloaded editor retains the changed prompt and 10-minute interval

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Implementation used GPT-6 Astra in Codex through T3 Code.

@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Sep 18, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c31b8df

Macroscope's review found this PR approvable — Adds a localized pencil action that routes each thread automation to the existing scheduled-task editor, while leaving task execution, pause/resume behavior, data contracts, and server code unchanged. The only other change is tooltip wording, making the runtime impact small and self-contained.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 12 times, most recently from a1f8051 to 0337dd6 Compare September 21, 2026 05:40
@juliusmarminge
juliusmarminge force-pushed the agent/web-automation-edit-ov2 branch from c31b8df to 33048ab Compare September 21, 2026 20:15
<Button
size="icon-xs"
variant="ghost"
className={THREAD_DETAILS_PANEL_ICON_ACTION_CLASS}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared primitives over custom controls: THREAD_DETAILS_PANEL_ICON_ACTION_CLASS overrides Button sizing, radius, padding, and base colors. Please move this treatment into a Button size/variant and use that here.

Suggested fix: No diff — this requires adding or extending the shared Button API.

Posted via Macroscope — UI Consistency

@juliusmarminge
juliusmarminge merged commit 9d6feae into pingdotgg:t3code/codex-turn-mapping Sep 21, 2026
22 checks passed
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 24, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 24, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 24, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 25, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants