Skip to content

t3code/ui composition audit/worklog link variant - #12375

Merged
juliusmarminge merged 1 commit into
t3code/codex-turn-mappingfrom
t3code/ui-composition-audit/worklog-link-variant
Sep 18, 2026
Merged

juliusmarminge merged 1 commit into
t3code/codex-turn-mappingfrom
t3code/ui-composition-audit/worklog-link-variant

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

The lifecycle “Open chat” action overrode InlineButton’s radius and link colors at the call site. InlineButton now owns the same treatment as variant="link", and the lifecycle action selects it without custom styling.

This addresses the remaining UI Consistency finding from #12347, which merged concurrently while the fix was being prepared. Appearance, interaction, and other InlineButton callers remain unchanged.

Validation: focused worktree/timeline tests, web typecheck, scoped lint, and a whole-PR source review. Code-only verification remains requested; no browser screenshots were collected.

Model: GPT-6. Harness: Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 18, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 93f8954

Macroscope's review found this PR approvable — This is a small UI refactor that centralizes existing link styling in an optional InlineButton variant. Existing callers and the worklog action retain their prior behavior, with no product-default, infrastructure, schema, or sensitive-code changes.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 93f8954.

This comment will update automatically after the next completed run.

@juliusmarminge
juliusmarminge merged commit 66948b5 into t3code/codex-turn-mapping Sep 18, 2026
22 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/ui-composition-audit/worklog-link-variant branch September 18, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant