Skip to content

refactor(mobile): share subagent status indicators - #12367

Merged
juliusmarminge merged 1 commit into
t3code/ui-composition-audit/error-alertsfrom
t3code/ui-composition-audit/subagent-status-dots
Sep 18, 2026
Merged

juliusmarminge merged 1 commit into
t3code/ui-composition-audit/error-alertsfrom
t3code/ui-composition-audit/subagent-status-dots

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

Retained in the V2 UI stack. The subagent sheet and V2 worklog consumers migrated here are absent from main.

Subagent sheets, worklogs, and spawn summaries duplicated status colors and dot geometry. SubagentStatusDot now owns the tone palette and explicit inline, provider-overlay, and sheet placements. Existing status mapping and child-thread navigation remain unchanged.

Validation: threadAgentsPresentation tests, affected client typecheck, scoped lint, and React Doctor review. React Doctor’s existing consumer findings remain documented from the original audit; no new component findings were identified.

Code-only verification was requested; no browser/device pass or before/after screenshots are included. This remains a draft for visual review. No wire contracts, persisted data, or upgrade migrations change.

Model: GPT-6. Harness: Codex.

@juliusmarminge
juliusmarminge added this pull request to stack #12350 September 18, 2026 02:51
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 18, 2026
@github-actions

github-actions Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 62fb533.

This comment will update automatically after the next completed run.

@juliusmarminge
juliusmarminge removed this pull request from stack #12350 September 18, 2026 02:57
@juliusmarminge
juliusmarminge changed the base branch from t3code/ui-composition-audit/request-actions to t3code/ui-composition-audit/error-alerts September 18, 2026 03:03
@juliusmarminge
juliusmarminge force-pushed the t3code/ui-composition-audit/subagent-status-dots branch from f66b014 to 26e3d61 Compare September 18, 2026 03:03
@juliusmarminge
juliusmarminge added this pull request to stack #12373 September 18, 2026 03:03
@github-actions github-actions Bot added the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Sep 18, 2026
@juliusmarminge
juliusmarminge marked this pull request as ready for review September 18, 2026 03:07
@macroscopeapp

macroscopeapp Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 26e3d61

Macroscope's review found this PR approvable — This PR centralizes duplicated subagent status-dot styling while preserving the existing status mappings, dimensions, and provider overlay placement. The change is limited to mobile presentation code and does not alter data, navigation, or product defaults.

No code changes detected at 62fb533. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge force-pushed the t3code/ui-composition-audit/subagent-status-dots branch from 26e3d61 to 62fb533 Compare September 18, 2026 03:15
@juliusmarminge
juliusmarminge merged commit 6bf8c7e into t3code/codex-turn-mapping Sep 18, 2026
27 of 39 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/ui-composition-audit/subagent-status-dots branch September 18, 2026 03:16
@github-actions github-actions Bot removed the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant