refactor(web): reuse shared error alerts - #12361
Merged
juliusmarminge merged 1 commit intoSep 18, 2026
Merged
juliusmarminge merged 1 commit into
juliusmarminge merged 1 commit into
Conversation
juliusmarminge
added this pull request to stack #12350
September 18, 2026 02:51
Contributor
Thread transfer impact
This comment will update automatically after the next completed run. |
juliusmarminge
removed this pull request from stack #12350
September 18, 2026 02:57
juliusmarminge
changed the base branch from
t3code/ui-composition-audit/settings-groups
to
t3code/ui-composition-audit/composer-labels
September 18, 2026 03:02
juliusmarminge
force-pushed
the
t3code/ui-composition-audit/error-alerts
branch
from
September 18, 2026 03:03
87bf3cb to
9997ec1
Compare
juliusmarminge
added this pull request to stack #12373
September 18, 2026 03:03
juliusmarminge
marked this pull request as ready for review
September 18, 2026 03:07
Contributor
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This is a contained UI refactor that standardizes error rendering without changing pairing, search, connection, or data-flow behavior. Human review is still required because the change includes an auth-directory file, which is treated as sensitive regardless of the narrow presentation scope. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
juliusmarminge
force-pushed
the
t3code/ui-composition-audit/error-alerts
branch
from
September 18, 2026 03:15
9997ec1 to
dfb7e35
Compare
juliusmarminge
merged commit Sep 18, 2026
c0ac828
into
t3code/codex-turn-mapping
26 of 37 checks passed
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 19, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 19, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 21, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 21, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 24, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 24, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 24, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retained in the V2 UI stack. The migration includes the ACP registry screen and onboarding changes currently present only on the V2 branch.
Pairing, onboarding, provider discovery, theme search, and connection settings hand-styled error banners. They now compose the existing Alert and AlertDescription primitives. Search live-region semantics and onboarding error references are preserved.
Validation: authBootstrap, hostedPairing, AcpRegistrySearchStep, and ConnectionsSettings.logic tests, affected client typecheck, scoped lint, and React Doctor review. React Doctor’s existing consumer findings remain documented from the original audit; no new component findings were identified.
Code-only verification was requested; no browser/device pass or before/after screenshots are included. This remains a draft for visual review. No wire contracts, persisted data, or upgrade migrations change.
Model: GPT-6. Harness: Codex.