Skip to content

refactor(web): reuse shared error alerts - #12361

Merged
juliusmarminge merged 1 commit into
t3code/ui-composition-audit/composer-labelsfrom
t3code/ui-composition-audit/error-alerts
Sep 18, 2026
Merged

juliusmarminge merged 1 commit into
t3code/ui-composition-audit/composer-labelsfrom
t3code/ui-composition-audit/error-alerts

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

Retained in the V2 UI stack. The migration includes the ACP registry screen and onboarding changes currently present only on the V2 branch.

Pairing, onboarding, provider discovery, theme search, and connection settings hand-styled error banners. They now compose the existing Alert and AlertDescription primitives. Search live-region semantics and onboarding error references are preserved.

Validation: authBootstrap, hostedPairing, AcpRegistrySearchStep, and ConnectionsSettings.logic tests, affected client typecheck, scoped lint, and React Doctor review. React Doctor’s existing consumer findings remain documented from the original audit; no new component findings were identified.

Code-only verification was requested; no browser/device pass or before/after screenshots are included. This remains a draft for visual review. No wire contracts, persisted data, or upgrade migrations change.

Model: GPT-6. Harness: Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 18, 2026
@juliusmarminge
juliusmarminge added this pull request to stack #12350 September 18, 2026 02:51
@juliusmarminge juliusmarminge changed the title refactor(web): use shared error alerts refactor(web): reuse shared error alerts Sep 18, 2026
@github-actions

github-actions Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for dfb7e35.

This comment will update automatically after the next completed run.

@juliusmarminge
juliusmarminge removed this pull request from stack #12350 September 18, 2026 02:57
@juliusmarminge
juliusmarminge changed the base branch from t3code/ui-composition-audit/settings-groups to t3code/ui-composition-audit/composer-labels September 18, 2026 03:02
@juliusmarminge
juliusmarminge force-pushed the t3code/ui-composition-audit/error-alerts branch from 87bf3cb to 9997ec1 Compare September 18, 2026 03:03
@juliusmarminge
juliusmarminge added this pull request to stack #12373 September 18, 2026 03:03
@github-actions github-actions Bot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Sep 18, 2026
@juliusmarminge
juliusmarminge marked this pull request as ready for review September 18, 2026 03:07
@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Sep 18, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This is a contained UI refactor that standardizes error rendering without changing pairing, search, connection, or data-flow behavior. Human review is still required because the change includes an auth-directory file, which is treated as sensitive regardless of the narrow presentation scope.

No code changes detected at dfb7e35. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge force-pushed the t3code/ui-composition-audit/error-alerts branch from 9997ec1 to dfb7e35 Compare September 18, 2026 03:15
@juliusmarminge
juliusmarminge merged commit c0ac828 into t3code/codex-turn-mapping Sep 18, 2026
26 of 37 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/ui-composition-audit/error-alerts branch September 18, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant