Skip to content

refactor(web): share composer context labels - #12357

Merged
juliusmarminge merged 1 commit into
t3code/ui-composition-audit/mobile-choicesfrom
t3code/ui-composition-audit/composer-labels
Sep 18, 2026
Merged

juliusmarminge merged 1 commit into
t3code/ui-composition-audit/mobile-choicesfrom
t3code/ui-composition-audit/composer-labels

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

Retained in the V2 UI stack. The consumers include the V2 thread-details panel display mode and its label APIs.

Composer context labels repeated truncation and compact-state styling, with inconsistent nested measurement spans and CSS timing. ComposerContextLabel now owns the measurable text structure and toolbar opacity defaults. Panel labels keep their full-width layout; existing composer measurement and FLIP behavior remain intact.

Validation: composerFooterLayout and restingComposerControlsMeasurement tests, affected client typecheck, scoped lint, and React Doctor review. React Doctor’s existing consumer findings remain documented from the original audit; no new component findings were identified.

Code-only verification was requested; no browser/device pass or before/after screenshots are included. This remains a draft for visual review. No wire contracts, persisted data, or upgrade migrations change.

Model: GPT-6. Harness: Codex.

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Sep 18, 2026
@juliusmarminge
juliusmarminge added this pull request to stack #12350 September 18, 2026 02:51
@github-actions github-actions Bot added the size:L 100-499 changed lines (additions + deletions). label Sep 18, 2026
@juliusmarminge juliusmarminge changed the title refactor(web): share composer context label layout refactor(web): share composer context labels Sep 18, 2026
@github-actions

github-actions Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for a5c1b15.

This comment will update automatically after the next completed run.

@juliusmarminge
juliusmarminge removed this pull request from stack #12350 September 18, 2026 02:57
@juliusmarminge
juliusmarminge force-pushed the t3code/ui-composition-audit/composer-labels branch from 379f3db to 6941ed3 Compare September 18, 2026 03:02
@juliusmarminge
juliusmarminge changed the base branch from t3code/ui-composition-audit/mobile-row-layout to t3code/ui-composition-audit/mobile-choices September 18, 2026 03:02
@juliusmarminge
juliusmarminge added this pull request to stack #12373 September 18, 2026 03:03
@github-actions github-actions Bot added 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. size:XXL 1,000+ changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Sep 18, 2026
@juliusmarminge
juliusmarminge marked this pull request as ready for review September 18, 2026 03:07
@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Sep 18, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 6941ed3

Macroscope's review found this PR approvable — This is a contained web UI refactor that centralizes repeated composer-label markup across four selectors. Its runtime impact is limited to label layout and animation styling, with no changes to user actions, data flow, APIs, or product defaults.

No code changes detected at a5c1b15. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge force-pushed the t3code/ui-composition-audit/composer-labels branch from 6941ed3 to a5c1b15 Compare September 18, 2026 03:15
@juliusmarminge
juliusmarminge merged commit 78f1d14 into t3code/codex-turn-mapping Sep 18, 2026
26 of 37 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/ui-composition-audit/composer-labels branch September 18, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant