refactor(mobile): share settings choice row defaults - #12349
Merged
juliusmarminge merged 1 commit intoSep 18, 2026
Merged
juliusmarminge merged 1 commit into
juliusmarminge merged 1 commit into
Conversation
juliusmarminge
added this pull request to stack #12350
September 18, 2026 02:22
Contributor
Thread transfer impact
This comment will update automatically after the next completed run. |
juliusmarminge
removed this pull request from stack #12350
September 18, 2026 02:57
juliusmarminge
added this pull request to stack #12373
September 18, 2026 03:03
juliusmarminge
marked this pull request as ready for review
September 18, 2026 03:07
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a localized extraction of an existing settings choice row, preserving selection, persistence, accessibility, and disabled-state behavior. The only runtime differences are bounded visual consistency improvements across the mobile settings screens. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
juliusmarminge
force-pushed
the
t3code/ui-composition-audit/mobile-choices
branch
from
September 18, 2026 03:15
1cc6e6c to
04b3e66
Compare
juliusmarminge
merged commit Sep 18, 2026
266c40f
into
t3code/codex-turn-mapping
26 of 38 checks passed
juliusmarminge
deleted the
t3code/ui-composition-audit/mobile-choices
branch
September 18, 2026 03:16
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 19, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 19, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 21, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 21, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 24, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 24, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 24, 2026
juliusmarminge
added a commit
that referenced
this pull request
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retained in the V2 UI stack. This migration includes the V2 follow-up settings screen, which is absent from main.
Keyboard, Follow-ups, and Project grouping repeated the Server Controls choice row but omitted its Android text sizing and pressed feedback. Each screen maintained its own spacing, selection checkmark, and radio accessibility markup.
Extract
SettingsChoiceRowfrom Server Controls and use it on all four screens. The component owns those defaults, includingandroid:text-base; screens retain their options, selection state, disabled conditions, and persistence callbacks. Deliberately different thread-settings radio controls remain separate.Validation: mobile typecheck, changed-file lint/format checks, and 11 existing settings/preference tests passed. React Doctor scanned the five changed files and reported only existing warnings in unchanged safe-area padding and Server Controls code.
Applies to iOS and Android settings. No preference schema, server, contracts, or migration changes; existing V2 preview state remains compatible. Simulator/browser verification and before/after captures were explicitly excluded from this code-only pass. Kept as a draft pending visual review.
Model: GPT-6. Harness: Codex.