Skip to content

refactor(mobile): share settings choice row defaults - #12349

Merged
juliusmarminge merged 1 commit into
t3code/ui-composition-audit/thread-detailsfrom
t3code/ui-composition-audit/mobile-choices
Sep 18, 2026
Merged

juliusmarminge merged 1 commit into
t3code/ui-composition-audit/thread-detailsfrom
t3code/ui-composition-audit/mobile-choices

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

Retained in the V2 UI stack. This migration includes the V2 follow-up settings screen, which is absent from main.

Keyboard, Follow-ups, and Project grouping repeated the Server Controls choice row but omitted its Android text sizing and pressed feedback. Each screen maintained its own spacing, selection checkmark, and radio accessibility markup.

Extract SettingsChoiceRow from Server Controls and use it on all four screens. The component owns those defaults, including android:text-base; screens retain their options, selection state, disabled conditions, and persistence callbacks. Deliberately different thread-settings radio controls remain separate.

Validation: mobile typecheck, changed-file lint/format checks, and 11 existing settings/preference tests passed. React Doctor scanned the five changed files and reported only existing warnings in unchanged safe-area padding and Server Controls code.

Applies to iOS and Android settings. No preference schema, server, contracts, or migration changes; existing V2 preview state remains compatible. Simulator/browser verification and before/after captures were explicitly excluded from this code-only pass. Kept as a draft pending visual review.

Model: GPT-6. Harness: Codex.

@juliusmarminge
juliusmarminge added this pull request to stack #12350 September 18, 2026 02:22
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 18, 2026
@github-actions

github-actions Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 04b3e66.

This comment will update automatically after the next completed run.

@juliusmarminge
juliusmarminge removed this pull request from stack #12350 September 18, 2026 02:57
@juliusmarminge
juliusmarminge added this pull request to stack #12373 September 18, 2026 03:03
@juliusmarminge
juliusmarminge marked this pull request as ready for review September 18, 2026 03:07
@macroscopeapp

macroscopeapp Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 1cc6e6c

Macroscope's review found this PR approvable — This is a localized extraction of an existing settings choice row, preserving selection, persistence, accessibility, and disabled-state behavior. The only runtime differences are bounded visual consistency improvements across the mobile settings screens.

No code changes detected at 04b3e66. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge force-pushed the t3code/ui-composition-audit/mobile-choices branch from 1cc6e6c to 04b3e66 Compare September 18, 2026 03:15
@juliusmarminge
juliusmarminge merged commit 266c40f into t3code/codex-turn-mapping Sep 18, 2026
26 of 38 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/ui-composition-audit/mobile-choices branch September 18, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant