Skip to content

refactor(web): centralize thread details section layout - #12348

Merged
juliusmarminge merged 1 commit into
t3code/ui-composition-audit/worklogfrom
t3code/ui-composition-audit/thread-details
Sep 18, 2026
Merged

juliusmarminge merged 1 commit into
t3code/ui-composition-audit/worklogfrom
t3code/ui-composition-audit/thread-details

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

Retained in the V2 UI stack. The thread detail, automation, and relationship panels migrated here are absent from main.

Workspace, Version Control, Automations, and Lineage each built their own thread-details section header. Their heights and horizontal insets had drifted, and none consistently owned title truncation.

Add ThreadDetailsSection and use it for all four sections. It owns the divider, content inset, single-line nonselectable heading, and action alignment. Consumers provide the title, actions, and content. Both the sidebar and popover use it; the existing scroll container and control behavior stay intact.

Validation: the three focused thread-details/lineage tests passed, including agent status updates and disclosure behavior. Web typecheck and changed-file lint passed. React Doctor found only existing warnings in the changed web files.

No server, contracts, persisted data, or migration changes. Browser verification and before/after captures were explicitly excluded from this code-only pass. Kept as a draft pending visual review.

Model: GPT-6. Harness: Codex.

@juliusmarminge
juliusmarminge added this pull request to stack #12350 September 18, 2026 02:22
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 0f6aa4e.

This comment will update automatically after the next completed run.

@juliusmarminge
juliusmarminge removed this pull request from stack #12350 September 18, 2026 02:57
@juliusmarminge
juliusmarminge added this pull request to stack #12373 September 18, 2026 03:03
@juliusmarminge
juliusmarminge marked this pull request as ready for review September 18, 2026 03:07
@macroscopeapp

macroscopeapp Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 0f6aa4e

Macroscope's review found this PR approvable — This PR centralizes existing thread-details section markup and makes only localized spacing and header-layout adjustments. Existing data flows, conditions, accessibility labels, and interactive behavior remain unchanged, with no sensitive, schema, deployment, default, or lint-configuration impact.

No code changes detected at e929da5. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge force-pushed the t3code/ui-composition-audit/thread-details branch from 0f6aa4e to e929da5 Compare September 18, 2026 03:15
@juliusmarminge
juliusmarminge merged commit b8e5c0b into t3code/codex-turn-mapping Sep 18, 2026
21 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/ui-composition-audit/thread-details branch September 18, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant