Skip to content

fix(web): hide idle PR check counts and match row typography - #12321

Merged
juliusmarminge merged 2 commits into
pingdotgg:t3code/codex-turn-mappingfrom
Bil0000:refine-checks-status-styling
Sep 17, 2026
Merged

juliusmarminge merged 2 commits into
pingdotgg:t3code/codex-turn-mappingfrom
Bil0000:refine-checks-status-styling

Conversation

@Bil0000

@Bil0000 Bil0000 commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

The workspace PR row kept showing check counts such as 15/20 after checks had finished. Its checks button also used larger text than the PR label.

Show the count only while checks are running, and use the same 13 px text size throughout the row. The status icon and checks menu remain available when the count is hidden. Checks awaiting approval do not count as running.

Before: completed checks still show 15/20

After: completed checks keep the status icon without a count

Verified on the rebased v2 head with six focused row tests, targeted lint and formatting, web typecheck, and the isolated real web app. The latest CI checks pass. Web and desktop share this row; no server, wire, or mobile code changed.

Model: GPT-6. Harness: OpenAI Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 17, 2026
Comment thread apps/web/src/components/chat/ThreadDetailsPrRow.tsx Outdated
@macroscopeapp

This comment has been minimized.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 17, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at fb6468d

Macroscope's review found this PR approvable — This is a small, self-contained web UI fix that limits behavior changes to hiding idle check counts and aligning typography in the workspace PR row. Focused tests cover the relevant check states, with no schema, server, infrastructure, security, billing, or static-analysis changes.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeapp
macroscopeapp Bot dismissed their stale review September 17, 2026 21:54

Dismissing prior approval to re-evaluate fb6468d

@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 2 times, most recently from 0c3df3a to d447298 Compare September 17, 2026 22:54
@juliusmarminge
juliusmarminge force-pushed the refine-checks-status-styling branch from fb6468d to af824ca Compare September 17, 2026 23:28
@juliusmarminge
juliusmarminge merged commit 6a69b86 into pingdotgg:t3code/codex-turn-mapping Sep 17, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants