Skip to content

fix: preserve linked PRs and show them in badge tooltips - #12262

Merged
juliusmarminge merged 5 commits into
pingdotgg:t3code/codex-turn-mappingfrom
Bil0000:fix-linked-pr-preservation
Sep 17, 2026
Merged

juliusmarminge merged 5 commits into
pingdotgg:t3code/codex-turn-mappingfrom
Bil0000:fix-linked-pr-preservation

Conversation

@Bil0000

@Bil0000 Bil0000 commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

When a thread shows the PR inferred from its branch, linking another PR hides the first one because only the new PR is saved. Save the displayed branch PR with the new manual link so both remain linked. Repeated links stay unique, and linking another PR does not restore a PR removed while other links remain.

Multi-PR and stack badge hovers now use the same compact status, number, and title rows as the thread hover. This shared control covers the sidebar and composer footer; single-PR behavior is unchanged.

Validation: 110 focused tests passed, including branch inference, repeated links, unlinking, and projection rebuilds. Web and server type checks passed. Targeted lint passed with existing warnings. Browser checks passed at 1280px and 390px, including mouse hover and keyboard focus. The shared server fix applies to all clients; the UI change applies to web and desktop.

Before and after images use synthetic data.

Before: multi-PR badge tooltip

After: linked PR list

After: narrow layout

The PR includes the same small CI repair used by the related V2 feedback PRs: remove unused exports, exercise conversation-only rollback in shared-workspace fixtures, and test checkpoint inspection without routing it through the feed that hides checkpoints. All 170 affected tests pass (one existing skip), and the scoped export check passes. Runtime file-restore safety is unchanged.

Model: GPT-6. Harness: Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 17, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 17, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at a923ef9

Macroscope's review found this PR approvable — This is a focused pull-request state fix and small UI presentation update: manually linking a PR now retains the discovered branch PR, while existing badges can show their persisted linked-PR list. Other edits are test-only, cleanup, or import/type maintenance, with no schema, deployment, security, or default changes.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeapp
macroscopeapp Bot dismissed their stale review September 17, 2026 15:33

Dismissing prior approval to re-evaluate dafa593

@juliusmarminge
juliusmarminge merged commit 7060b34 into pingdotgg:t3code/codex-turn-mapping Sep 17, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants