fix(v2): preserve running turns during provider handoff - #12255
Merged
juliusmarminge merged 6 commits intoSep 17, 2026
Merged
juliusmarminge merged 6 commits into
juliusmarminge merged 6 commits into
Conversation
Contributor
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The PR changes provider-handoff eligibility and message dispatch ordering across shared runtime, server, web, and mobile code. It also changes persisted provider failure text to suppress arbitrary cause data, making the cross-cutting runtime and sensitive error-data impact appropriate for human review. You can add or adjust custom eligibility rules. Learn more. |
macroscopeapp
Bot
dismissed
their stale review
September 17, 2026 14:31
Dismissing prior approval to re-evaluate 3b01afe
macroscopeapp
Bot
dismissed
their stale review
September 17, 2026 15:32
Dismissing prior approval to re-evaluate 11dae2c
macroscopeapp
Bot
dismissed
their stale review
September 17, 2026 15:37
Dismissing prior approval to re-evaluate 183861d
macroscopeapp
Bot
dismissed
their stale review
September 17, 2026 16:40
Dismissing prior approval to re-evaluate 9b2a1cd
This comment has been minimized.
This comment has been minimized.
juliusmarminge
force-pushed
the
fix-provider-handoff-feedback
branch
from
September 17, 2026 19:09
40fc60e to
70d98fe
Compare
juliusmarminge
merged this pull request
into
pingdotgg:t3code/codex-turn-mapping
Sep 17, 2026
24 checks passed
juliusmarminge
added a commit
that referenced
this pull request
Sep 17, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 17, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 17, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 17, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 18, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 19, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 19, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 21, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 21, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 23, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 23, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 23, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 23, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 23, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 23, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 24, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 24, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 24, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge
added a commit
that referenced
this pull request
Sep 25, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What remains after rebasing
#12226 is now in this PR's base branch. Its model-selection events, premature client-update removal, and queued cross-provider handoff stay in that base; the overlapping commits and replay were dropped from this PR.
This PR keeps distinct handoff fixes:
Evidence
After the rebase, 129 focused tests across the changed server, mobile, and web paths passed. Server, web, mobile, and client-runtime typechecks passed. Formatting and lint on the 15 changed files passed. All running CI checks passed on the rebased head; the approvability check was skipped.
Before:
After:
Narrow viewport:
Model: GPT-6. Harness: Codex.