Skip to content

fix(v2): preserve running turns during provider handoff - #12255

Merged
juliusmarminge merged 6 commits into
pingdotgg:t3code/codex-turn-mappingfrom
Bil0000:fix-provider-handoff-feedback
Sep 17, 2026
Merged

juliusmarminge merged 6 commits into
pingdotgg:t3code/codex-turn-mappingfrom
Bil0000:fix-provider-handoff-feedback

Conversation

@Bil0000

@Bil0000 Bil0000 commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

What remains after rebasing

#12226 is now in this PR's base branch. Its model-selection events, premature client-update removal, and queued cross-provider handoff stay in that base; the overlapping commits and replay were dropped from this PR.

This PR keeps distinct handoff fixes:

  • Imported threads can offer a provider handoff before a provider session exists, while a preparing turn remains bound until its session appears; session capabilities control established turns.
  • Automatic messages queue while the active handoff run is preparing or starting.
  • Handoff rows show provider logos and model names, with account names available on hover or tap.
  • Provider failure text uses an explicit safe message or the normalized default instead of arbitrary nested cause text.

Evidence

After the rebase, 129 focused tests across the changed server, mobile, and web paths passed. Server, web, mobile, and client-runtime typechecks passed. Formatting and lint on the 15 changed files passed. All running CI checks passed on the rebased head; the approvability check was skipped.

Before: Handoff row before model names were visible

After: Handoff row with provider and model names

Narrow viewport: Handoff row with names wrapping on a narrow viewport

Model: GPT-6. Harness: Codex.

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Sep 17, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 17, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The PR changes provider-handoff eligibility and message dispatch ordering across shared runtime, server, web, and mobile code. It also changes persisted provider failure text to suppress arbitrary cause data, making the cross-cutting runtime and sensitive error-data impact appropriate for human review.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeapp
macroscopeapp Bot dismissed their stale review September 17, 2026 14:31

Dismissing prior approval to re-evaluate 3b01afe

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 17, 2026
@Bil0000 Bil0000 changed the title fix: restore provider handoffs for imported threads and clarify their status fix: restore imported-thread handoffs and show model names Sep 17, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review September 17, 2026 15:32

Dismissing prior approval to re-evaluate 11dae2c

@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Sep 17, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 17, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review September 17, 2026 15:37

Dismissing prior approval to re-evaluate 183861d

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 17, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review September 17, 2026 16:40

Dismissing prior approval to re-evaluate 9b2a1cd

Comment thread apps/server/src/orchestration-v2/Orchestrator.ts
Comment thread apps/server/src/orchestration-v2/ProviderFailure.ts Outdated
Comment thread apps/server/src/orchestration-v2/Orchestrator.ts Outdated
Comment thread apps/server/src/orchestration-v2/Orchestrator.ts Outdated
Comment thread apps/server/src/orchestration-v2/Orchestrator.ts
@macroscopeapp

This comment has been minimized.

@Bil0000 Bil0000 changed the title fix: restore imported-thread handoffs and show model names fix(v2): preserve running turns during provider handoff Sep 17, 2026
@juliusmarminge
juliusmarminge force-pushed the fix-provider-handoff-feedback branch from 40fc60e to 70d98fe Compare September 17, 2026 19:09
@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Sep 17, 2026
@juliusmarminge
juliusmarminge merged this pull request into pingdotgg:t3code/codex-turn-mapping Sep 17, 2026
24 checks passed
juliusmarminge added a commit that referenced this pull request Sep 17, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 17, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 17, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 17, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 18, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 18, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 18, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 18, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 18, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 18, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 18, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 18, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 19, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 19, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 21, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 21, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 23, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 23, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 23, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 23, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 23, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 23, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 24, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 24, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 24, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge added a commit that referenced this pull request Sep 25, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants