fix(mobile): preview queued message order during drag - #12232
Conversation
Thread transfer impact
This comment will update automatically after the next completed run. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused mobile queue-drag fix that previews the destination by animating nearby rows while preserving the existing reorder command and unchanged-drop behavior. The implementation is localized, tested, and introduces no schema, infrastructure, security, billing, or configuration changes. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughChangesThread queue drag handling
Priority: ⬇️ Low Estimated code review effort: 4 (Complex) | ~45 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant QueueRow
participant ThreadQueueControl
participant resolveQueueDragBeforeRunId
QueueRow->>ThreadQueueControl: Start and move drag
ThreadQueueControl->>resolveQueueDragBeforeRunId: Resolve preview target
resolveQueueDragBeforeRunId-->>ThreadQueueControl: Return insertion anchor
QueueRow->>ThreadQueueControl: End drag
ThreadQueueControl->>resolveQueueDragBeforeRunId: Resolve final target
ThreadQueueControl->>QueueRow: Animate row into position
Merge Risk: ⚪ Minimal · up to No merge-blocking issue was identified in the queue drag preview changes. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
b7f9f13
into
t3code/codex-turn-mapping
Queued messages on mobile stayed in place while a message was dragged. The destination was hard to judge until the drag ended.
What changed
The queued-message sheet now previews the insertion point during a drag. Nearby messages animate into the open space as the dragged message crosses them. The final reorder still uses the existing server command, and an unchanged drop sends no reorder.
Why
The preview uses each row's original layout for hit testing and changes the insertion anchor only when the dragged message crosses another row. This keeps the drag responsive while preserving the server-authoritative queue order.
Verification
The three failing CI jobs reproduce the same failures on the parent PR: unused exports in Check, a web checkpoint test in Test, and four server rollback tests in Test Server 3. This child changes only mobile queue presentation code.
Checklist
Model: undisclosed. Harness: Codex.
Summary by CodeRabbit