Skip to content

fix(web): place notification icons after titles - #12209

Open
voltcrash wants to merge 1 commit into
pingdotgg:mainfrom
voltcrash:fix/notification-icon-after-title
Open

voltcrash wants to merge 1 commit into
pingdotgg:mainfrom
voltcrash:fix/notification-icon-after-title

Conversation

@voltcrash

@voltcrash voltcrash commented Sep 17, 2026 •

Copy link
Copy Markdown

Iterates on #12202

Notification status icons currently sit before the title while the description starts at the content edge, leaving the title and description misaligned.

Move built-in status icons and custom leading icons after the title in the shared toast body. This keeps titles and descriptions on the same left edge for regular and anchored notifications across web and desktop.

Verification

  • vp lint apps/web/src/components/ui/toast.tsx --report-unused-disable-directives
  • vp fmt --check apps/web/src/components/ui/toast.tsx
  • vp run --filter @t3tools/web typecheck
  • vp test run src/components/ui/toast.logic.test.ts src/components/ui/toastHelpers.test.ts --project unit (13 tests)

Screenshots

Before

SCR-20260917-jvxj

After

SCR-20260917-jvko

Model: gpt-5.6-sol. Harness: Codex.

Summary by CodeRabbit

  • Style
    • Adjusted toast notification layout so titles appear before leading icons for improved visual consistency.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 17, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 6fd4602

Macroscope's review found this PR approvable — This is a minimal, isolated toast layout fix that only reorders existing title and notification icon elements so titles align with descriptions across regular and anchored notifications. It introduces no new capability, schema change, deployment change, or static-analysis override.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 989e2807-873a-464f-a4cd-1b89c8d56b4d

📥 Commits

Reviewing files that changed from the base of the PR and between 01eb4b9 and 6fd4602.

📒 Files selected for processing (1)
  • apps/web/src/components/ui/toast.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The change moves Toast.Title to the start of the title and icon row in ToastBodyContent, before the optional leading icon and default icon branches.

Changes

Toast layout

Layer / File(s) Summary
Title and icon row order
apps/web/src/components/ui/toast.tsx
Toast.Title now renders before the optional leading icon and default icon branches. The previous title position was removed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: maria-rcks

Merge Risk: ⚪ Minimal · up to 6fd46

This is a localized toast layout adjustment with no identified behavior or availability risk, so it is ready to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main change: moving notification icons after toast titles.
Description check ✅ Passed The description explains the change, the alignment problem, verification steps, and UI results with before-and-after screenshots. It does not include the template headings or checklist, but the requir…
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant