Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a minimal, isolated toast layout fix that only reorders existing title and notification icon elements so titles align with descriptions across regular and anchored notifications. It introduces no new capability, schema change, deployment change, or static-analysis override. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe change moves ChangesToast layout
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to This is a localized toast layout adjustment with no identified behavior or availability risk, so it is ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Iterates on #12202
Notification status icons currently sit before the title while the description starts at the content edge, leaving the title and description misaligned.
Move built-in status icons and custom leading icons after the title in the shared toast body. This keeps titles and descriptions on the same left edge for regular and anchored notifications across web and desktop.
Verification
vp lint apps/web/src/components/ui/toast.tsx --report-unused-disable-directivesvp fmt --check apps/web/src/components/ui/toast.tsxvp run --filter @t3tools/web typecheckvp test run src/components/ui/toast.logic.test.ts src/components/ui/toastHelpers.test.ts --project unit(13 tests)Screenshots
Before
After
Model: gpt-5.6-sol. Harness: Codex.
Summary by CodeRabbit