Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a contained server-side bug fix that improves checkpoint capture for cone-mode sparse checkouts while preserving existing non-sparse behavior and the user's Git index. The added tests cover sparse-index variants and degraded index states, with no product-default or static-analysis configuration changes. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthrough
ChangesSparse checkpoint capture
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix · Severity of issue fixed: Medium Sequence Diagram(s)sequenceDiagram
participant captureCheckpoint
participant GitConfig
participant TemporaryIndex
participant GitIndex
participant Checkpoint
captureCheckpoint->>GitConfig: read sparse checkout settings
captureCheckpoint->>TemporaryIndex: copy and inspect index
TemporaryIndex->>GitIndex: refresh assumed entries and detect deletions
GitIndex-->>captureCheckpoint: reuse or rebuild decision
captureCheckpoint->>Checkpoint: capture sparse-aware file state
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The sparse-checkout checkpoint changes are mergeable after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Closing as superseded by #12154, which is now merged and covers the same sparse-checkpoint fix. |
Large cone-mode sparse checkouts rejected checkpoint index reuse, then failed on untracked files outside the cone.
Keep the copied index and refresh it with Git instead of listing every tracked path. When a fresh index is needed, stage existing files first, then apply in-cone deletions. This preserves excluded tracked files, captures outside-cone artifacts, and leaves the workspace index untouched.
Fixes #12080.
Verification:
Reviewed with Claude Opus 5; review findings fixed and rechecked.
Model: GPT-6. Harness: Codex.
Summary by CodeRabbit