Repository navigation
fix(web): consume plans on new-thread implementation - #1203
Merged
juliusmarminge merged 5 commits intoApr 1, 2026
Merged
juliusmarminge merged 5 commits into
juliusmarminge merged 5 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks done
binbandit
approved these changes
Mar 19, 2026
youpele52
referenced
this pull request
in youpele52/bigbud
Jun 17, 2026
NeilTheFisher
pushed a commit
to NeilTheFisher/t3code
that referenced
this pull request
Aug 18, 2026
polymaniadeveloper-hub
pushed a commit
to Tevin2119/t3code
that referenced
this pull request
Oct 3, 2026
…emselves From the review of the T3 transitions (task pingdotgg#1203: Claude Opus, GLM, Kimi, DeepSeek; nothing blocking): - A move sends the column the card was seen in; the engine refuses it if the card stands elsewhere now, so a stale drop cannot become a step nobody asked for. - A refused column in the task view can be chosen: it moves nothing and shows why, for sighted users on any device as well as screen readers. It was disabled, with the reason only in a tooltip that could not appear. - A second press while a request is out says so instead of vanishing. - The lane hint names a step as its button does (Mark part as reviewed, Try publishing again); a card in a refused lane shows no drop ring. - Triage while a seat works is refused with that reason. - Publishing sends the commit the dialog names. - Team defaults are saved with the revision they were read at, and the engine refuses a save over a newer one; the seat dialogs keep the save's answer until the next read arrives, then take the read, and never empty the form on an answer they cannot read. - The Seats button says on screen why it is disabled. - A seat's defined fallbacks fall back to the chain in use on an engine that does not send them. - The Claude usage comment no longer says the capabilities budget bounds the usage request. Needs the engine at Operation-PaperClip fix/transitions-2. Typecheck clean; lint adds nothing new; deliveryBoard and delivery tests 62 of 62. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #978
Continues #1133 (see https://pr-navigator.pages.dev/t3code-utkarsh).
What Changed
This extends plan consumption to the
Implement in a new threadflow #1133.PR 1133 introduced the shared plan-consumption plumbing and applied it to same-thread
Implement. This PR wires the remaining caller: when the user choosesImplement in a new thread, the new thread’sthread.turn.startcommand now includessourceProposedPlan.That allows the existing orchestration and runtime-ingestion path to mark the source proposed plan as implemented when the new thread’s implementation turn actually starts, so the original plan thread no longer has the "Plan Ready" label.
Why
Before this change, the same-thread implementation flow consumed the plan, but the new-thread implementation flow still started an implementation turn without identifying which source plan it came from.
That left the original thread in a stale "Plan Ready" state even though the plan was already being implemented elsewhere.
This PR keeps the behavior consistent across both implementation entrypoints by reusing the same source-plan mechanism introduced in PR 1133.
UI Changes
Combined the before/after videos and posted it on X because the files' sizes were too large to upload here: https://x.com/UtkarshUsername/status/2033161459447087223?s=20
PR Context
This PR continues on top of:
fix/consume-plan-on-same-thread-implementationSee https://pr-navigator.pages.dev/t3code-utkarsh.

Made this a different PR because it solves a different pre-existing problem. Actually, I had solved this first, but changed the order to make reviewing easier.
Checklist
Note
[!NOTE]
Include
sourceProposedPlanmetadata in orchestration dispatch for new-thread flowWhen starting a new thread from a proposed plan, the orchestration action payload in ChatView.tsx now includes a
sourceProposedPlanobject carrying the originatingthreadIdandplanId. This ensures the plan is consumed/associated correctly when a thread is created from it.Macroscope summarized c84b472.
Note
Low Risk
Small, localized change that only adds metadata to an existing orchestration dispatch; risk is limited to plan-consumption behavior and edge cases around missing/incorrect plan IDs.
Overview
Fixes the "Implement in a new thread" flow to pass
sourceProposedPlanin thethread.turn.startorchestration command, linking the new implementation turn back to the originating proposed plan (bythreadId/planId).This enables the existing plan-consumption path to mark the original plan as implemented so the source thread no longer remains in a stale "Plan Ready" state when implementation starts in a separate thread.
Written by Cursor Bugbot for commit c84b472. This will update automatically on new commits. Configure here.