Skip to content

feat(swift-ios): show bundled open source licenses - #11695

Merged
t3dotgg merged 3 commits into
t3code/rebuild-mobile-app-swiftfrom
t3code/swift-parity-licenses
Sep 14, 2026
Merged

t3dotgg merged 3 commits into
t3code/rebuild-mobile-app-swiftfrom
t3code/swift-parity-licenses

Conversation

@t3dotgg

@t3dotgg t3dotgg commented Sep 14, 2026 •

Copy link
Copy Markdown
Member

SwiftUI has no way to read the licenses for the code it ships. Settings now has a searchable list of bundled license notices with full text and source links. It works offline.

The snapshot covers pinned Clerk, Nuke, and PhoneNumberKit packages, plus GhosttyKit and its bundled libraries and fonts. It uses upstream license files and notices from the pinned source archives. The iOS archive was checked to identify bundled libraries. The simdutf notice uses version 9.0.0 from its vendored header, not the stale 5.2.8 package label.

The generator updates Swift package pins and checks the Ghostty revision. Run node apps/swift-ios/Scripts/sync-license-notices.mjs to refresh notices, or add --check to verify the saved dependency metadata without network requests.

Validation: generator, metadata check, JavaScript syntax check, targeted formatter, and git diff --check passed. The central native run passed NativeLicenseCatalogTests, 1 test, with the shipped app resource. UI evidence remains part of the central integration pass. No build, simulator, or release channel was changed here.

Created with Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 14, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new production license-browser screen, bundled legal-notice data, searching, detail navigation, and external source links. The implementation is localized, but the new user-facing component and associated runtime content warrant human review.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 13.6 KiB — 15.1 KiB ✅
Codex Thread snapshot wire — 7.0 KiB — 7.3 KiB ✅
Codex Live turn WebSocket wire — 6.6 KiB — 7.8 KiB ✅
Codex Live turn WebSocket decoded — 57.1 KiB — 66.4 KiB ✅
Codex Live turn messages — 10 — 21 ✅
Claude Total thread wire — 13.6 KiB — 15.1 KiB ✅
Claude Thread snapshot wire — 7.1 KiB — 7.3 KiB ✅
Claude Live turn WebSocket wire — 6.5 KiB — 7.8 KiB ✅
Claude Live turn WebSocket decoded — 57.8 KiB — 66.4 KiB ✅
Claude Live turn messages — 9 — 21 ✅

Baseline: unavailable · PR result: 1d0aa8f · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@t3dotgg
t3dotgg merged commit 5b9939f into t3code/rebuild-mobile-app-swift Sep 14, 2026
24 checks passed
@t3dotgg
t3dotgg deleted the t3code/swift-parity-licenses branch September 14, 2026 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500-999 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant