Skip to content

feat(swift-ios): support linked pull requests and GitHub sharing - #11693

Merged
t3dotgg merged 5 commits into
t3code/rebuild-mobile-app-swiftfrom
t3code/swift-parity-pr-links
Sep 14, 2026
Merged

t3dotgg merged 5 commits into
t3code/rebuild-mobile-app-swiftfrom
t3code/swift-parity-pr-links

Conversation

@t3dotgg

@t3dotgg t3dotgg commented Sep 14, 2026 •

Copy link
Copy Markdown
Member

SwiftUI only read one linked pull request and could not use GitHub account sharing.

Read the full thread PR list, keep badges and search in sync, and add link and unlink actions. Open PR still opens the external URL. GitHub sharing is off by default and requires saved-endpoint permission and matching accounts on both environments.

Verified with ThreadPullRequestsTests, GitHubRoutingTests, NativeGitHubRoutingTests, and NativeThreadMetadataTests. Native CI and repository CI pass. Macroscope correctness is green, with all review findings resolved. Integrated UI evidence is handled with the main SwiftUI branch.

Created with Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 14, 2026
@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 13.6 KiB — 15.1 KiB ✅
Codex Thread snapshot wire — 7.0 KiB — 7.3 KiB ✅
Codex Live turn WebSocket wire — 6.6 KiB — 7.8 KiB ✅
Codex Live turn WebSocket decoded — 57.1 KiB — 66.4 KiB ✅
Codex Live turn messages — 10 — 21 ✅
Claude Total thread wire — 13.6 KiB — 15.1 KiB ✅
Claude Thread snapshot wire — 7.0 KiB — 7.3 KiB ✅
Claude Live turn WebSocket wire — 6.5 KiB — 7.8 KiB ✅
Claude Live turn WebSocket decoded — 57.8 KiB — 66.4 KiB ✅
Claude Live turn messages — 9 — 21 ✅

Baseline: unavailable · PR result: 750613a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Comment thread apps/swift-ios/Core/ThreadPullRequests.swift Outdated
Comment thread apps/swift-ios/App/NativeFeatureClient.swift
Comment thread apps/swift-ios/Core/ThreadPullRequests.swift
Comment thread apps/swift-ios/Features/Workspace/WorkspaceView.swift Outdated
@macroscopeapp

macroscopeapp Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds substantial production behavior: multi-PR thread linking plus cross-environment GitHub routing for reads and externally visible PR writes. The new wire contracts, account verification, credential-bound routing, and user-facing permission controls create a broad blast radius that requires human review.

You can add or adjust custom eligibility rules. Learn more.

@github-actions github-actions Bot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 14, 2026
Comment thread apps/swift-ios/App/NativeFeatureClient.swift
@t3dotgg
t3dotgg force-pushed the t3code/swift-parity-pr-links branch from 8e0ab7e to 4a4607e Compare September 14, 2026 04:43
@t3dotgg
t3dotgg force-pushed the t3code/swift-parity-pr-links branch from 4a4607e to 750613a Compare September 14, 2026 04:47
@t3dotgg
t3dotgg merged commit 8034880 into t3code/rebuild-mobile-app-swift Sep 14, 2026
24 checks passed
@t3dotgg
t3dotgg deleted the t3code/swift-parity-pr-links branch September 14, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant