Skip to content

feat(swift-ios): show native crash reports in settings - #11689

Merged
t3dotgg merged 3 commits into
t3code/rebuild-mobile-app-swiftfrom
t3code/swift-parity-diagnostics
Sep 14, 2026
Merged

t3dotgg merged 3 commits into
t3code/rebuild-mobile-app-swiftfrom
t3code/swift-parity-diagnostics

Conversation

@t3dotgg

@t3dotgg t3dotgg commented Sep 14, 2026

Copy link
Copy Markdown
Member

SwiftUI users cannot retrieve native crash and slow-launch reports from the app. Settings now shows reports delivered by Apple's MetricKit, with report preview, copy, share, and clear actions.

The app keeps five reports, capped at 256 KB each. Larger reports retain their reporting period and counts. Reports can arrive on a later launch. The screen does not treat an empty list as proof that no crash occurred. Sharing is explicit because Apple reports can include exception details.

Added focused tests for retention, duplicate delivery, size limits, and clearing. Xcode tests and UI evidence will be checked in the central integration pass. No simulator, device, or build channel was changed here.

Created with Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 14, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds an always-on MetricKit subscriber, persistent native diagnostic storage, and a new Settings workflow for viewing, copying, sharing, and clearing reports. Because it introduces new production behavior and exposes potentially sensitive crash details, the change warrants human review.

You can add or adjust custom eligibility rules. Learn more.

Comment thread apps/swift-ios/App/Platform/NativeDiagnostics.swift Outdated
@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 13.5 KiB — 15.1 KiB ✅
Codex Thread snapshot wire — 7.0 KiB — 7.3 KiB ✅
Codex Live turn WebSocket wire — 6.5 KiB — 7.8 KiB ✅
Codex Live turn WebSocket decoded — 57.0 KiB — 66.4 KiB ✅
Codex Live turn messages — 8 — 21 ✅
Claude Total thread wire — 13.6 KiB — 15.1 KiB ✅
Claude Thread snapshot wire — 7.1 KiB — 7.3 KiB ✅
Claude Live turn WebSocket wire — 6.5 KiB — 7.8 KiB ✅
Claude Live turn WebSocket decoded — 57.8 KiB — 66.4 KiB ✅
Claude Live turn messages — 8 — 21 ✅

Baseline: unavailable · PR result: 1081294 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@t3dotgg
t3dotgg merged commit 7c54c00 into t3code/rebuild-mobile-app-swift Sep 14, 2026
24 checks passed
@t3dotgg
t3dotgg deleted the t3code/swift-parity-diagnostics branch September 14, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant