Conversation
Member
|
Thanks for the PR. We're not taking changes to the orchestration and provider layers right now: that part of the server is being rewritten for V2, and merging into the current code would either conflict with or be thrown away by that work. Closing for now. If this is still an issue once V2 lands, please reopen (or open a fresh PR against the new code) and we'll take a proper look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Grok context usage now reaches the existing web/desktop context-window indicator. Parse ACP
usage_updatenotifications into validated token snapshots, emitthread.token-usage.updatedfrom the Grok adapter, and advertise context-window reporting in Grok provider snapshots.Why
The ACP parser previously dropped usage notifications, leaving Grok threads without context-window data. The adapter now forwards session usage even outside an active turn, preserves zero usage, and treats a zero capacity as unknown. Invalid token values are ignored. The existing event contract carries updates across local and remote connections.
Validation
vp test run GrokAdapter GrokProvider AcpRuntimeModel.Manual check: start an isolated dev environment, open its pairing URL, enable Grok and Settings → General → Context window indicator (legacy), then send a Grok prompt. Confirm the indicator shows used tokens and capacity when the CLI emits usage, and updates on subsequent turns.
Checklist
Implemented with GPT-6 using the Codex harness.