Skip to content

fix(server): replay all command events across persistence pages - #11160

Closed
kiiwee wants to merge 429 commits into
pingdotgg:t3code/codex-turn-mappingfrom
kiiwee:fix/v2-command-replay-pagination-20260911
Closed

fix(server): replay all command events across persistence pages#11160
kiiwee wants to merge 429 commits into
pingdotgg:t3code/codex-turn-mappingfrom
kiiwee:fix/v2-command-replay-pagination-20260911

Conversation

@kiiwee

@kiiwee kiiwee commented Sep 11, 2026

Copy link
Copy Markdown

Command replay silently stopped after the persistence layer's default 1,000-event limit. Page command-filtered reads by sequence so every stored event is returned in order while each database read remains bounded.

The SQLite regression returned only 1,000 of 1,001 matching events before the fix, with unrelated events interleaved. All 36 foundation persistence tests now pass, including empty and single-page replay. Targeted type-aware lint, type checking, and formatting pass for both changed files.

Targets Orchestrator V2 in #2829.

Engineering: Grok 4.6 through Grok Build CLI; review and verification: Codex through the Codex harness.

juliusmarminge and others added 30 commits September 10, 2026 12:14
@juliusmarminge @claude
perf(web): keep timeline minimap animations off the main thread
0ee69f0 
A renderer performance trace showed the minimap strips as a standing
source of main-thread frame work: each strip transitioned
background-color (paint) and width (layout), and both fire constantly —
scrolling or streaming flips a band of in-view states at once, and the
hover fisheye animates several widths at a time — so any interaction
kept a 60fps style/layout/paint pipeline running.

The strip now animates only compositor-friendly properties: width tiers
are scale-x on a fixed-width box, and the in-view highlight is a bright
overlay faded with opacity. The scroll handler also skips no-op
data-in-view attribute writes, which previously re-dirtied style state
for every strip on every scroll tick.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
feat(orchestration): port thread title regeneration to the v2 runtime
6211c05 
Follow-ups from the main merge:

- Migration numbering: main's 035_ProjectionThreadTitleRegeneration is
  released and keeps its id; this branch's unreleased v2 migrations shift
  to 036-044 instead (a released migration can never be renumbered).
- thread.metadata.update accepts regenerateTitle: true arms an in-flight
  titleRegeneration marker on the thread payload (requestId + startedAt),
  a landing title or explicit false clears it. The marker projects onto
  thread shells and through the client-runtime shell model, so the
  sidebar's Regenerating state works unchanged.
- New ThreadTitleRegenerationService worker reacts to armed markers on
  the live domain-event stream (so ws, MCP, and mobile dispatches all
  behave the same): builds a newest-first conversation digest from the
  v2 projection (8k-char budget, retained attachments — ported from the
  v1 reactor), generates via TextGeneration, and lands the title with a
  follow-up metadata update. Failures clear the marker and log.
- The server advertises threadTitleRegeneration again, and the client
  updateThreadMetadata dispatches regenerateTitle-only updates.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Yusuf007R @juliusmarminge
fix(orchestration): thread visits no longer create activity loops (pi…
6b989f7 
…ngdotgg#5038)
@juliusmarminge @claude
fix(orchestration): promoted queued messages keep the queued_turn intent
960d91e 
The turn item materialized when a queued run is promoted was emitted
with inputIntent "turn_start", but the deterministic replay driver (and
the recorded queued_turn fixtures) expect "queued_turn" — the mismatch
stalled replay before the queued run could start, leaving run 1 waiting
and run 2 queued forever in all five queued_turn fixtures.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
refactor(orchestration): split thread-not-sendable into typed errors
b10a121 
Effect service conventions: ThreadManagementThreadNotSendableError
carried an Archived/NoSteerableRun reason union and switched on
reason._tag inside the message getter. Modelled as two error classes
(ThreadManagementThreadArchivedError, ThreadManagementNoSteerableRunError);
both still map to the MCP thread_not_sendable failure code.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
fix(web): remove elevated thread details panel styling
393d871
@juliusmarminge
fix(web): keep Git progress title anchored
ae50c95 
- Prevent the title row from shifting when output is revealed
- Preserve panel and compact button sizing
@maria-rcks @juliusmarminge
fix: reconcile rebase with latest main
0009caa
@Yusuf007R @juliusmarminge
fix(orchestration-v2): restore generated thread titles (pingdotgg#5176)
58579e7
@mwolson @juliusmarminge
fix(orchestrator): Order thread lineage by creation time (pingdotgg#5310
88b4988 
)
@juliusmarminge @claude
fix(server): restore worktree branch naming in the v2 orchestrator (p…
984ee6b 
…ingdotgg#5309)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@maria-rcks @juliusmarminge
feat(chat): refine V2 conversation UI (pingdotgg#5307)
86039e8
@juliusmarminge @claude
fix: adopt effect beta.103 APIs in rebased v2 code
8f597e8 
- Schema.UnknownFromJsonString -> Schema.fromJsonString(Schema.Unknown)
- SchemaIssue.InvalidValue single-argument form in checkpointDiff
- McpServerClient requires protocolVersion

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
fix: send mcp-protocol-version header in worktree registration test
4494873 
Required for follow-up requests by the 2025-06-18 MCP HTTP transport
that effect beta.103 enforces.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
fix(web): restore compact header sizing for project script controls
96d4e39 
The thread-panel mapping change replaced the compact className on the
Run and Add controls with the isPanel conditional and dropped the
non-panel icon-compact classes that the responsive test asserts.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
test(server): cover v2 thread title regeneration
4458102 
Ports the deleted v1 ProviderCommandReactor title coverage onto the v2
service: marker arming/clearing via thread.metadata.update, superseded
requestId no-ops, digest-driven regeneration, the "New thread" and
unchanged-title fallbacks, generation failure, and missing initial
messages, plus unit tests for formatThreadTitleContext.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
chore: resolve lint warnings across v2 code
b0f4319 
Hoist inline Schema compiles to module scope, drop unused
imports/vars, stabilize react-markdown component identities via a
module-scope factory, remove useless spreads, and use data-derived
keys for release-note bullets. No behavior changes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
fix(test): keep codex replay recovery off the repo checkout
d9e962c 
The codex resume test was the only replay scenario without a
runtimePolicyOverride, so its checkpoint scope cwd fell back to
process.cwd() and baseline capture ran real git over the entire
checkout. Locally the capture short-circuits on checkpoint refs left
behind by earlier runs; on a fresh CI checkout it is a cold multi-second
capture that outlives the scenario wait budget, failing await_thread_idle
while the run is still mid-checkpoint. Point the fixture's turn/start
frames at the <workspace> placeholder and checkpoint a throwaway git
workspace like every other replay test.

Scenario waits are also wall-clock-bounded now: the iteration budget
counts event-loop turns, which burn at full speed while git/fixture IO
is in flight, so exhaustion additionally requires a 60s real-time
deadline to pass.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@mwolson @juliusmarminge
fix(orchestrator): Prevent redundant delegated completion turns (ping…
cb85d87 
…dotgg#5311)
@juliusmarminge @claude
fix(server): stop tying codex text-generation temp files to the calle…
cf3675e 
…r's scope (pingdotgg#5406)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
fix(web): remove open PR actions from git controls
946e0b3 
- Keep the git action control disabled when the branch is up to date
- Omit open PR menu entries and remove their link-opening behavior
- Update logic tests for the new states
@juliusmarminge @claude
fix(server): renumber v2 migrations after main's 036_ProjectionThread…
1ca15b8 
…sPinned

Main owns migration numbering: 036_ProjectionThreadsPinned landed on main,
so the v2 migrations shift from 036-044 to 037-045. Release path runs all
of main's migrations first, then the v2 stack.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
fix: port main fixes stranded by the v2 rewrite
98b7b33 
- Port thread pinning (pingdotgg#5312) into the orchestration-v2 command pipeline:
  thread.pin/unpin commands, thread.pinned/unpinned events, pinnedAt on the
  v2 thread state and projected shells, promotion semantics (pin clears
  settle/snooze, settle clears pin) matching the v1 decider, and client
  pin/unpin operations in the v2 dispatch style.
- Port the regenerated-title context anchoring (pingdotgg#5365) into
  ThreadTitleRegenerationService: pin the first user message ahead of the
  retained tail when the digest is truncated.
- Re-apply the right-panel controls positioning from pingdotgg#5260 to the v2
  ChatView title bar controls.
- Repair merge artifacts: committed conflict markers in BranchToolbar,
  duplicate capability keys, duplicate CommandPalette import, v1 turn
  naming in DiffPanel's focus-refresh effect, onSend signature merge.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
test(server): align migration expectations with renumbered ids
87b65da 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@mwolson @juliusmarminge
feat(orchestrator): Surface waiting background work (pingdotgg#4378)
66a5332
@juliusmarminge
fix(web): align git action progress button layout
3a9e823 
- Match progress button spacing and single-line height to static git actions
@juliusmarminge @claude
fix: repair conflict-marker artifacts from rebase auto-resolutions
2072818 
rerere replayed stale resolutions during the rebase and committed nested
conflict markers in several files. Restore the branch-intended v2 shapes
and re-graft main's compatible additions (pending-card opacity comments,
theme-editor keybinding test, mobile scroll re-arm effects from pingdotgg#5566).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
fix(server): renumber v2 migrations after main's 037_ProjectionTurnsK…
8c15a6a 
…eysetIndex

Main owns migration numbering: 037_ProjectionTurnsKeysetIndex landed on
main (pingdotgg#5493), so the v2 migrations shift from 037-045 to 038-046.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
fix: port main fixes stranded by the v2 rewrite (round 2)
68d0b76 
Native subagent observability (pingdotgg#5219), wired per its spec's v2 merge plan:
- getWorkflowScript RPC re-homed onto the v2 WS surface (contracts, rpc
  group, ws handler, auth scope, client atom).
- AgentsPanel fed by the spec's mapper swap: projectedSubagentsToRuntime
  maps orchestration-v2 subagent entities into the panel model;
  deriveAgentPanelModel's v2Projection leg is now live and the v1 fold
  never runs. Agents surface wired into ChatView + RightPanelTabs.
Other ports and reconciliations:
- Shell reconnect-loop fix (pingdotgg#5561) ported into the v2 shell sync
  (same-session resubscribes resume from the in-memory cursor), with the
  cursor-resume regression test adapted to v2 fixtures.
- Mobile end-follow latch (pingdotgg#5566) ported onto the v2 ThreadFeed.
- Claude ede_diagnostic interrupt classification (pingdotgg#5557) ported into
  ClaudeAdapterV2 (aborted_tools/aborted_streaming => interrupted; CLI
  telemetry never becomes the failure banner). pingdotgg#5559 needs no v2 port
  (unknown system subtypes are already ignored).
- Plan sidebar removed from the v2 ChatView/ChatComposer per main's
  plans-fold-into-chat rework (pingdotgg#5558); rightPanelStore stays at main's
  surface set.
- SettingsPanels rebuilt as main's refactored version plus the branch's
  composer-context setting; sidebar snooze respects the time format
  (pingdotgg#4438 follow-through).
- v1-only leftovers deleted: zombie v1 adapters/ingestion/tests the v2
  rewrite removes, the v1-bound transfer-budget CI harness (pingdotgg#5350, needs
  a v2 rebuild), and main's v1 client pagination machinery (pingdotgg#5493 client
  side; the 037 keyset migration is kept — server-side v2 windowing is a
  follow-up).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
chore(web): prune plan-sidebar leftovers after the inline-plans rework
1aca37d 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
juliusmarminge and others added 14 commits September 10, 2026 16:08
@juliusmarminge
fix(server): distinguish delegated task results from completed turns
74e6af2
@juliusmarminge
test(server): align Codex delegation instruction assertion
f20359d
@juliusmarminge
test(server): align delegation fixtures with task result semantics
55a5258
@saphid @github-actions
fix(server): classify Claude V2 structured terminal failures (pingdot…
c495cce 
…gg#9897)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@saphid @github-actions @juliusmarminge
fix(orchestration): exclude rolled-back work from bounded recovery (p…
8ced7ef 
…ingdotgg#8464)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
@saphid @github-actions
test(orchestration): cover bounded V2 socket fallback paging (pingdot…
233063a 
…gg#9907)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@saphid @github-actions @juliusmarminge
fix(server): wait for native Codex start before Stop (pingdotgg#10024)
49fa325 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
@saphid @github-actions @juliusmarminge
fix(server): keep the native Grok default model (pingdotgg#10025)
95ad9fe 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
@saphid @github-actions
fix(server): fail V2 turns when the OpenCode event stream ends (pingd…
209fe68 
…otgg#9905)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@saphid @github-actions
fix(web): preserve file attachments when editing queued runs (pingdot…
f92bb31 
…gg#9928)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@saphid @github-actions
fix(server): preserve project mutation fields across transports (ping…
1c9e0f4 
…dotgg#9920)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@saphid @github-actions
fix(mobile): throttle streaming thread visit updates (pingdotgg#9931)
2e07740 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@saphid @github-actions @juliusmarminge
fix(orchestrator): preserve task-step elapsed time across restart (pi…
89459e3 
…ngdotgg#10051)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
@kiiwee
fix(server): replay all command events across persistence pages
5c95518
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 11, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 5c95518

Macroscope's review found this PR approvable — This is a narrowly scoped server bug fix that preserves existing persistence contracts while paging command-event reads so large replays are complete. Its regression coverage includes interleaved events and the 1,001-event boundary, with no product-default or static-analysis changes.

You can add or adjust custom eligibility rules. Learn more.

@cjavad cjavad mentioned this pull request Sep 11, 2026
Open
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 4 times, most recently from e03e376 to e39429e Compare September 12, 2026 08:17
@saphid saphid mentioned this pull request Sep 13, 2026
Merged
2 tasks
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 4 times, most recently from 463d0c6 to e10a1e2 Compare September 15, 2026 06:28
@juliusmarminge

juliusmarminge commented Sep 15, 2026

Copy link
Copy Markdown
Member

Superseded — the same cross-page replay fix landed via #11499, which ports it to the current persistence layout (persistence/Layers/OrchestrationEventStore.ts). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macroscopeapp macroscopeapp[bot] macroscopeapp[bot] approved these changes

Assignees

No one assigned

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kiiwee @juliusmarminge @Yusuf007R @maria-rcks @mwolson @saphid @StiensWout