Conversation
Contributor
ApprovabilityVerdict: Would Approve Macroscope's review found this PR approvable — This is a narrowly scoped Codex Stop bug fix that pauses an active persisted goal before interrupting turns, with bounded best-effort handling and regression coverage for ordering. The remaining changes extend only the integration-test mock and test assertions. Not approved because:
Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more. |
Mjones13
force-pushed
the
fix/goal-pause-on-stop
branch
from
September 7, 2026 01:48
54b3592 to
63c97e1
Compare
This was referenced Sep 9, 2026
Open
2 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stopping a Codex turn can leave its persisted native goal active, allowing the scheduler to inject continuation turns immediately after Stop.
Read the thread goal and pause it only when active, before interrupting the child fleet and root turn. Bound the combined goal lookup/update to one second and ignore goal-control errors so Stop still reaches turn interruption. Extend the collab mock and queued-follow-up regression to assert goal pause precedes the active root turn interrupt.
Validation: original commit
54b359252440a17c59bee6dc77bbf9eaaeac407cwas recovered intact from the contributor fork. Sequential source self-review completed; current-upstream synchronization and current-revision CI verification are in progress. Historical reports of 11 focused integration tests plus lint/format/server typecheck are not being presented as fresh results. No merge or deployment is requested by this publication.Model and harness: GPT-6 Astra Pro, ChatGPT GitHub + Scratch (Level 2), one agent with sequential self-review.