-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat(web): find messages and plans in the current thread #10439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
5e08741
feat(web): find messages and plans in the current thread
Noojuno c0c6225
fix(web): keep thread highlight helpers private
Noojuno 8912f9c
fix(web): improve thread search contrast and use an opaque bar
Noojuno 6ac5972
feat(web): make thread search highlights themeable
Noojuno 716a4ad
fix(web): match thread search bar to control radius
Noojuno 3133aba
fix(web): align thread search with rendered text
Noojuno 5d03337
fix(web): search older thread history automatically
Noojuno 9a5ada4
fix(web): keep partial search results when history fails
Noojuno e7b7d59
fix(web): use shared sizing for the thread find bar
Noojuno 729ecae
refactor(web): simplify thread search rendering and cleanup
Noojuno a2dd75a
fix(web): preserve attachment extraction and find escape priority
Noojuno b2970b1
feat(search): find thread messages on the server
Noojuno 11bc859
chore(search): remove relocated Markdown dependencies
Noojuno 33b5dd2
chore(search): keep Markdown extraction helper private
Noojuno 1bf7fe6
fix(search): require the wrapped search error cause
Noojuno e0136a5
fix(search): align rebased find with upstream APIs
Noojuno 18068ca
refactor(search): consolidate find state and remove forwarding modules
Noojuno 7679ced
fix(search): cover review text and thread lifecycle edge cases
Noojuno 7481e89
fix(search): align rebased find with upstream message contexts
Noojuno c117b2a
fix(search): match file chips and reveal hidden results
Noojuno b76026b
refactor(search): clarify shared helper ownership
Noojuno fb72d50
fix(web): soften idle search highlights and use warm amber
Noojuno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Medium
Layers/ProjectionSnapshotQuery.ts:3772searchThreadreturns archived threads as searchable becausemakeThreadFindQueryfilters onlydeleted_at IS NULL, unlikegetActiveThreadRowById, which also requiresarchived_at IS NULL. An RPC using an archived thread ID therefore returns its messages and plans even though theProjectionSnapshotQueryShapecontract is for active threads and the normal detail endpoint rejects that thread. Add thearchived_at IS NULLpredicate to the query used bymakeThreadFindQuery, or avoid exposing this search path for archived threads.🤖 Copy this AI Prompt to have your agent fix this: