Skip to content

fix(server): preserve due tasks when time formatting changes - #10438

Closed
CouchRiv wants to merge 429 commits into
pingdotgg:t3code/codex-turn-mappingfrom
CouchRiv:fix/server-scheduled-time-equality
Closed

fix(server): preserve due tasks when time formatting changes#10438
CouchRiv wants to merge 429 commits into
pingdotgg:t3code/codex-turn-mappingfrom
CouchRiv:fix/server-scheduled-time-equality

Conversation

@CouchRiv

@CouchRiv CouchRiv commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown

What Changed

Fixed-time schedules now compare parsed hours and minutes, so saving 09:00 instead of 9:00 preserves the pending occurrence.

Why

Both formats are accepted by the schedule contract. The current string comparison treats them as a schedule change and recalculates the next run. If today's occurrence is already due but has not dispatched, that save can postpone it until tomorrow.

This targets the V2 branch in #2829. It reuses the existing time parser and leaves actual hour, minute, weekday and interval changes distinct.

Validation

Rebased and revalidated on V2 89459e38, where migration 051 now creates the scheduled-task schema; the service test imports that migration.

  • Four new regression cases fail before the fix; all 15 focused scheduler and contract tests pass afterward.
  • The service test uses real input decoding, in-memory SQLite and a controlled clock. It verifies the preserved persisted deadline and that changing the time to 09:30 still reschedules.
  • Server typecheck and targeted lint, formatting and diff checks pass.

Checklist

  • This PR is small and focused
  • I explained what changed and why

Implemented with GPT-6 in the Codex harness; rebased and revalidated with Claude Opus 5 in Claude Code.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 7, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — The production change narrowly fixes equality for equivalent fixed-time schedule formats, preventing an otherwise unnecessary save from postponing a pending run. It leaves actual schedule changes and interval behavior intact and includes focused regression coverage.

Not approved because:

  • Monthly spending limit reached (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 3 times, most recently from efd9994 to 6102d00 Compare September 8, 2026 06:23
@CouchRiv
CouchRiv force-pushed the fix/server-scheduled-time-equality branch from c8d297f to 00c081f Compare September 8, 2026 18:13
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch from 8187b17 to ada72ce Compare September 9, 2026 06:39
juliusmarminge and others added 22 commits September 10, 2026 12:14
@juliusmarminge @claude
perf(web): keep timeline minimap animations off the main thread
0ee69f0 
A renderer performance trace showed the minimap strips as a standing
source of main-thread frame work: each strip transitioned
background-color (paint) and width (layout), and both fire constantly —
scrolling or streaming flips a band of in-view states at once, and the
hover fisheye animates several widths at a time — so any interaction
kept a 60fps style/layout/paint pipeline running.

The strip now animates only compositor-friendly properties: width tiers
are scale-x on a fixed-width box, and the in-view highlight is a bright
overlay faded with opacity. The scroll handler also skips no-op
data-in-view attribute writes, which previously re-dirtied style state
for every strip on every scroll tick.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
feat(orchestration): port thread title regeneration to the v2 runtime
6211c05 
Follow-ups from the main merge:

- Migration numbering: main's 035_ProjectionThreadTitleRegeneration is
  released and keeps its id; this branch's unreleased v2 migrations shift
  to 036-044 instead (a released migration can never be renumbered).
- thread.metadata.update accepts regenerateTitle: true arms an in-flight
  titleRegeneration marker on the thread payload (requestId + startedAt),
  a landing title or explicit false clears it. The marker projects onto
  thread shells and through the client-runtime shell model, so the
  sidebar's Regenerating state works unchanged.
- New ThreadTitleRegenerationService worker reacts to armed markers on
  the live domain-event stream (so ws, MCP, and mobile dispatches all
  behave the same): builds a newest-first conversation digest from the
  v2 projection (8k-char budget, retained attachments — ported from the
  v1 reactor), generates via TextGeneration, and lands the title with a
  follow-up metadata update. Failures clear the marker and log.
- The server advertises threadTitleRegeneration again, and the client
  updateThreadMetadata dispatches regenerateTitle-only updates.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Yusuf007R @juliusmarminge
fix(orchestration): thread visits no longer create activity loops (pi…
6b989f7 
…ngdotgg#5038)
@juliusmarminge @claude
fix(orchestration): promoted queued messages keep the queued_turn intent
960d91e 
The turn item materialized when a queued run is promoted was emitted
with inputIntent "turn_start", but the deterministic replay driver (and
the recorded queued_turn fixtures) expect "queued_turn" — the mismatch
stalled replay before the queued run could start, leaving run 1 waiting
and run 2 queued forever in all five queued_turn fixtures.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
refactor(orchestration): split thread-not-sendable into typed errors
b10a121 
Effect service conventions: ThreadManagementThreadNotSendableError
carried an Archived/NoSteerableRun reason union and switched on
reason._tag inside the message getter. Modelled as two error classes
(ThreadManagementThreadArchivedError, ThreadManagementNoSteerableRunError);
both still map to the MCP thread_not_sendable failure code.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
fix(web): remove elevated thread details panel styling
393d871
@juliusmarminge
fix(web): keep Git progress title anchored
ae50c95 
- Prevent the title row from shifting when output is revealed
- Preserve panel and compact button sizing
@maria-rcks @juliusmarminge
fix: reconcile rebase with latest main
0009caa
@Yusuf007R @juliusmarminge
fix(orchestration-v2): restore generated thread titles (pingdotgg#5176)
58579e7
@mwolson @juliusmarminge
fix(orchestrator): Order thread lineage by creation time (pingdotgg#5310
88b4988 
)
@juliusmarminge @claude
fix(server): restore worktree branch naming in the v2 orchestrator (p…
984ee6b 
…ingdotgg#5309)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@maria-rcks @juliusmarminge
feat(chat): refine V2 conversation UI (pingdotgg#5307)
86039e8
@juliusmarminge @claude
fix: adopt effect beta.103 APIs in rebased v2 code
8f597e8 
- Schema.UnknownFromJsonString -> Schema.fromJsonString(Schema.Unknown)
- SchemaIssue.InvalidValue single-argument form in checkpointDiff
- McpServerClient requires protocolVersion

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
fix: send mcp-protocol-version header in worktree registration test
4494873 
Required for follow-up requests by the 2025-06-18 MCP HTTP transport
that effect beta.103 enforces.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
fix(web): restore compact header sizing for project script controls
96d4e39 
The thread-panel mapping change replaced the compact className on the
Run and Add controls with the isPanel conditional and dropped the
non-panel icon-compact classes that the responsive test asserts.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
test(server): cover v2 thread title regeneration
4458102 
Ports the deleted v1 ProviderCommandReactor title coverage onto the v2
service: marker arming/clearing via thread.metadata.update, superseded
requestId no-ops, digest-driven regeneration, the "New thread" and
unchanged-title fallbacks, generation failure, and missing initial
messages, plus unit tests for formatThreadTitleContext.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
chore: resolve lint warnings across v2 code
b0f4319 
Hoist inline Schema compiles to module scope, drop unused
imports/vars, stabilize react-markdown component identities via a
module-scope factory, remove useless spreads, and use data-derived
keys for release-note bullets. No behavior changes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
fix(test): keep codex replay recovery off the repo checkout
d9e962c 
The codex resume test was the only replay scenario without a
runtimePolicyOverride, so its checkpoint scope cwd fell back to
process.cwd() and baseline capture ran real git over the entire
checkout. Locally the capture short-circuits on checkpoint refs left
behind by earlier runs; on a fresh CI checkout it is a cold multi-second
capture that outlives the scenario wait budget, failing await_thread_idle
while the run is still mid-checkpoint. Point the fixture's turn/start
frames at the <workspace> placeholder and checkpoint a throwaway git
workspace like every other replay test.

Scenario waits are also wall-clock-bounded now: the iteration budget
counts event-loop turns, which burn at full speed while git/fixture IO
is in flight, so exhaustion additionally requires a 60s real-time
deadline to pass.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@mwolson @juliusmarminge
fix(orchestrator): Prevent redundant delegated completion turns (ping…
cb85d87 
…dotgg#5311)
@juliusmarminge @claude
fix(server): stop tying codex text-generation temp files to the calle…
cf3675e 
…r's scope (pingdotgg#5406)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
fix(web): remove open PR actions from git controls
946e0b3 
- Keep the git action control disabled when the branch is up to date
- Omit open PR menu entries and remove their link-opening behavior
- Update logic tests for the new states
@juliusmarminge @claude
fix(server): renumber v2 migrations after main's 036_ProjectionThread…
1ca15b8 
…sPinned

Main owns migration numbering: 036_ProjectionThreadsPinned landed on main,
so the v2 migrations shift from 036-044 to 037-045. Release path runs all
of main's migrations first, then the v2 stack.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
juliusmarminge and others added 15 commits September 10, 2026 16:08
@juliusmarminge
fix(acp): preserve native child messages and final summaries
df4f3af
@juliusmarminge
fix(server): distinguish delegated task results from completed turns
74e6af2
@juliusmarminge
test(server): align Codex delegation instruction assertion
f20359d
@juliusmarminge
test(server): align delegation fixtures with task result semantics
55a5258
@saphid @github-actions
fix(server): classify Claude V2 structured terminal failures (pingdot…
c495cce 
…gg#9897)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@saphid @github-actions @juliusmarminge
fix(orchestration): exclude rolled-back work from bounded recovery (p…
8ced7ef 
…ingdotgg#8464)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
@saphid @github-actions
test(orchestration): cover bounded V2 socket fallback paging (pingdot…
233063a 
…gg#9907)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@saphid @github-actions @juliusmarminge
fix(server): wait for native Codex start before Stop (pingdotgg#10024)
49fa325 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
@saphid @github-actions @juliusmarminge
fix(server): keep the native Grok default model (pingdotgg#10025)
95ad9fe 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
@saphid @github-actions
fix(server): fail V2 turns when the OpenCode event stream ends (pingd…
209fe68 
…otgg#9905)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@saphid @github-actions
fix(web): preserve file attachments when editing queued runs (pingdot…
f92bb31 
…gg#9928)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@saphid @github-actions
fix(server): preserve project mutation fields across transports (ping…
1c9e0f4 
…dotgg#9920)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@saphid @github-actions
fix(mobile): throttle streaming thread visit updates (pingdotgg#9931)
2e07740 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@saphid @github-actions @juliusmarminge
fix(orchestrator): preserve task-step elapsed time across restart (pi…
89459e3 
…ngdotgg#10051)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
@CouchRiv
fix(server): preserve due tasks when time formatting changes
9744897
@CouchRiv
CouchRiv force-pushed the fix/server-scheduled-time-equality branch from 00c081f to 9744897 Compare September 11, 2026 19:06
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 4 times, most recently from e03e376 to e39429e Compare September 12, 2026 08:17
@saphid saphid mentioned this pull request Sep 13, 2026
Merged
@saphid

saphid commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Rebased adaptation of this fix for the current V2 base is in #11590 — same semantic time comparison, service test moved onto the full in-memory migration chain. Crediting this proposal there.

@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 2 times, most recently from 600a8a5 to d8c75ec Compare September 15, 2026 00:23
saphid pushed a commit to saphid/t3code that referenced this pull request Sep 15, 2026
@github-actions @devin-ai-integration
fix(server): preserve due schedules across equivalent time formatting
7c5698b 
Fixed-time schedule equality compared timeOfDay strings, so saving a
task with "09:00" over "9:00" was treated as a schedule change and
recomputed next_run_at — deferring an occurrence that was already due.
Compare parsed hours/minutes instead; real time, weekday, and interval
changes still reschedule.

Adapted from pingdotgg#10438 (CouchRiv), rebased onto current V2
with the service test on the full in-memory migration chain.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 2 times, most recently from 463d0c6 to e10a1e2 Compare September 15, 2026 06:28
juliusmarminge pushed a commit to saphid/t3code that referenced this pull request Sep 15, 2026
@github-actions @devin-ai-integration @juliusmarminge
fix(server): preserve due schedules across equivalent time formatting
656d7dc 
Fixed-time schedule equality compared timeOfDay strings, so saving a
task with "09:00" over "9:00" was treated as a schedule change and
recomputed next_run_at — deferring an occurrence that was already due.
Compare parsed hours/minutes instead; real time, weekday, and interval
changes still reschedule.

Adapted from pingdotgg#10438 (CouchRiv), rebased onto current V2
with the service test on the full in-memory migration chain.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@juliusmarminge

juliusmarminge commented Sep 15, 2026

Copy link
Copy Markdown
Member

Stale duplicate of #11590 — same parsed-time comparison fix on the current branch. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@CouchRiv @saphid @juliusmarminge @Yusuf007R @maria-rcks @mwolson @StiensWout