Skip to content

fix(mobile): show background monitoring status - #10436

Open
Gigioxx wants to merge 1 commit into
pingdotgg:mainfrom
Gigioxx:t3code/fix-issue-10372
Open

Gigioxx wants to merge 1 commit into
pingdotgg:mainfrom
Gigioxx:t3code/fix-issue-10372

Conversation

@Gigioxx

@Gigioxx Gigioxx commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Mobile looked idle after a turn completed even when the server still reported background monitoring or work. Both thread lists now show Monitoring or Working, and the open thread reuses the same status resolver for its floating label. Monitoring stays static and disappears when liveness clears. Existing approval, input, error, and plan priorities are preserved.

Fixes #10372.

Verified the regression fails on the original code and passes with the fix: 62 focused tests, mobile typecheck, and scoped lint with the same 23 existing warnings. React Doctor's before/after diagnostics are unchanged. On an iPhone 17 Pro simulator, checked Monitoring, Working, and cleared liveness in the default list and open thread. The legacy list is covered by resolver tests; Android and iPad share the changed components but were not run separately.

Screenshots use a disposable environment with a completed parent turn and controlled server liveness. They verify native presentation, not a live provider watch loop. No server or contract changes ship.

Default list: before Default list: after
Before: monitoring thread shows only a timestamp After: thread shows Monitoring
Open thread: before Open thread: after
Before: no monitoring indicator above the composer After: static Monitoring label above the composer

Model: GPT-6. Harness: Codex in T3 Code.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 7, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a localized mobile presentation fix that surfaces an existing background-liveness state in thread lists and the open-thread status control. It preserves existing priorities and processing behavior, with focused coverage and no schema, infrastructure, security, or configuration changes.

Not approved because:

  • Monthly spending limit reached (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more.

@cristip73

Copy link
Copy Markdown

@Gigioxx thanks for this fix. It stopped applying after #13183 retired the legacy thread list and threadPresentation.ts, so it is now conflicting on 4 files.

I ported it onto current main in #13803, with you as co-author on the commit. The logic is yours. It follows the triage on #10372 and also closes #4962, the "subagents still running, phone says idle" case. If you would rather rebase this PR yourself, say so and I will close mine. The goal is just to get one of them mergeable.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: iOS does not show Monitoring status displayed on desktop and web

2 participants