Repository navigation
Add nix flake devshell - #10135
Closed
theduke wants to merge 2 commits into
Closed
Add nix flake devshell#10135theduke wants to merge 2 commits into
theduke wants to merge 2 commits into
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Adds only a pinned Nix development shell and local tool dependencies; it does not alter product behavior, application paths, deployment, or production configuration. You can add or adjust custom eligibility rules. Learn more. |
With recent changes `npm run build` doesn't work anymore on baseline NixOS due to native library requirements. This adds a Nix flake with a devshell that has the required deps.
macroscopeapp
Bot
dismissed
their stale review
September 5, 2026 14:33
Dismissing prior approval to re-evaluate bea986b
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With recent changes
npm run builddoesn't work anymore on baselineNixOS due to native library requirements.
This adds a Nix flake with a devshell that has the required deps.
Checklist
Note
Add Nix flake development shell with Node.js, pnpm, and libsecret
Adds a
flake.nixthat defines a development shell forx86_64-linuxandaarch64-linux, pinning nixpkgs to the NixOS unstable channel. The shell provides Node.js, pnpm, pkg-config, libsecret, and the system C compiler toolchain. Aflake.locklocks the nixpkgs input.📊 Macroscope summarized bea986b. 1 file reviewed, 1 issue evaluated, 1 issue filtered, 0 comments posted
🗂️ Filtered Issues
flake.nix — 0 comments posted, 1 evaluated, 1 filtered
pkgs.libsecretinstalls only libsecret's defaultoutoutput in this shell, but its headers andlibsecret-1.pcare split into the separatedevoutput. Consequentlypkg-config --cflags --libs libsecret-1, which the desktop build invokes, cannot find the package innix develop; addpkgs.libsecret.dev(or otherwise include that output). [ Out of scope (triage) ]