Skip to content

Add nix flake devshell - #10135

Closed
theduke wants to merge 2 commits into
pingdotgg:mainfrom
theduke:nix-flake
Closed

theduke wants to merge 2 commits into
pingdotgg:mainfrom
theduke:nix-flake

Conversation

@theduke

@theduke theduke commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

With recent changes npm run build doesn't work anymore on baseline
NixOS due to native library requirements.

This adds a Nix flake with a devshell that has the required deps.

Checklist

  • This PR is small and focused
  • I explained what changed and why

Note

Add Nix flake development shell with Node.js, pnpm, and libsecret

Adds a flake.nix that defines a development shell for x86_64-linux and aarch64-linux, pinning nixpkgs to the NixOS unstable channel. The shell provides Node.js, pnpm, pkg-config, libsecret, and the system C compiler toolchain. A flake.lock locks the nixpkgs input.

📊 Macroscope summarized bea986b. 1 file reviewed, 1 issue evaluated, 1 issue filtered, 0 comments posted

🗂️ Filtered Issues

flake.nix — 0 comments posted, 1 evaluated, 1 filtered
  • line 23: pkgs.libsecret installs only libsecret's default out output in this shell, but its headers and libsecret-1.pc are split into the separate dev output. Consequently pkg-config --cflags --libs libsecret-1, which the desktop build invokes, cannot find the package in nix develop; add pkgs.libsecret.dev (or otherwise include that output). [ Out of scope (triage) ]

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 5, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 1c24bfb

Macroscope's review found this PR approvable — Adds only a pinned Nix development shell and local tool dependencies; it does not alter product behavior, application paths, deployment, or production configuration.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 5, 2026
With recent changes `npm run build` doesn't work anymore on baseline
NixOS due to native library requirements.

This adds a Nix flake with a devshell that has the required deps.
@macroscopeapp
macroscopeapp Bot dismissed their stale review September 5, 2026 14:33

Dismissing prior approval to re-evaluate bea986b

@juliusmarminge

Copy link
Copy Markdown
Member

Closing as part of the open-PR backlog sweep (wave 3).

Reason: Nix flake again; prior flakes #4699/#2734 already closed
Related: #4699

Reopen if this is still wanted and you’re willing to rebase onto current main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants