pilotctl: honor hidden and renamed_to catalogue entries - #484
Closed
Alexgodoroja wants to merge 1 commit into
Closed
Alexgodoroja wants to merge 1 commit into
Alexgodoroja wants to merge 1 commit into
Conversation
The catalogue marks io.pilot.smolmachines hidden and renamed_to io.pilot.smol, but pilotctl read neither field: the stub was still listed, and installing it failed with "placeholder sha256 — the release pipeline hasn't filled this in yet". Hidden entries are now left out of the listing, and installing a renamed id installs the app it moved to (one hop), with a notice on stderr. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Collaborator
|
Closing as superseded by #473, which merged today and implements |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The signed catalogue marks
io.pilot.smolmachinesas"hidden": true, "renamed_to": "io.pilot.smol", but pilotctl read neither field:pilotctl appstore cataloguestill listed "Smol Machines (renamed → io.pilot.smol)".pilotctl appstore install io.pilot.smolmachinesfailed with the misleadingcatalogue entry io.pilot.smolmachines has placeholder sha256 — the release pipeline hasn't filled this in yet.Fix
catalogueEntrygainsHiddenandRenamedTo. Hidden entries are left out of the text listing;--jsonstill returns them, with the flag.--version) followsrenamed_toone hop and printsnote: X was renamed to Y — installing Yon stderr. A rename pointing at a missing app gets a clear error instead.Tests
zz_appstore_renamed_test.gocovers the hidden listing, installing through a rename (unpacks the new app's bundle and prints the notice), and a rename to a missing app.go test ./cmd/pilotctl/is green.Found during the app-store audit.
🤖 Generated with Claude Code